[Asterisk-code-review] stasis: Re-set the PBX pointer before attempting to join the dial bridge (...asterisk[16.3])

Holger Hans Peter Freyther asteriskteam at digium.com
Wed Apr 10 02:55:20 CDT 2019


Hello Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/11255

to look at the new patch set (#2).

Change subject: stasis: Re-set the PBX pointer before attempting to join the dial bridge
......................................................................

stasis: Re-set the PBX pointer before attempting to join the dial bridge

As part of departing the pbx of the stasis control will be restored. Attempting
to join the dial bridge will then fail. Swap out the PBX again.

TODO: Does this hold true universally, if not remove the assert.

 0x000055555561a234 in ast_channel_pbx_set
 692             chan->pbx = value;
 (gdb) bt
 #0  0x000055555561a234 in ast_channel_pbx_set
 #1  0x00007fffc9fee0ea in internal_bridge_after_cb
     at stasis/control.c:1139
 #2  bridge_after_cb_failed
 #3  0x00005555555d95ef in after_bridge_cb_failed
 #4  after_bridge_cb_run_discard
 #5  ast_bridge_discard_after_callback
 #6  0x00005555555d070b in bridge_channel_depart_thread
 #7  0x0000555555710e7c in dummy_start
 #8  0x00007ffff5b5c4a4 in start_thread
 #9  0x00007ffff4766d0f in clone

ASTERISK-26718

Change-Id: I788151b7045791d1d5d35453875027a60e6d527a
---
M res/stasis/control.c
1 file changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/55/11255/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11255
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16.3
Gerrit-Change-Id: I788151b7045791d1d5d35453875027a60e6d527a
Gerrit-Change-Number: 11255
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190410/ef08209a/attachment.html>


More information about the asterisk-code-review mailing list