[Asterisk-code-review] chan_pjsip: DTMF Mode auto_info fallback lead to both inband and info (...asterisk[13])

[Joshua Colp]

Hello Salah Ahmed,

I'd like you to do a code review. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/11235

to review the following change.


Change subject: chan_pjsip: DTMF Mode auto_info fallback lead to both inband and info
......................................................................

chan_pjsip: DTMF Mode auto_info fallback lead to both inband and info

When the dtmf_mode on an endpoint is configured as "auto_info"
Asterisk will produce an inband DTMF tone alongside an INFO
message when sending DTMF.

ASTERISK-28371
Change-Id: I1380b82f006e110a1b83fbb50c9873edd13a5d9a

Change-Id: I9e348db15be0ece827eba8135c0591c53da8c802
---
M channels/chan_pjsip.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/35/11235/1

diff --git a/channels/chan_pjsip.c b/channels/chan_pjsip.c
index 36cc0ad..6d027b3 100644
--- a/channels/chan_pjsip.c
+++ b/channels/chan_pjsip.c
@@ -1758,7 +1758,7 @@
 		break;
 	case AST_SIP_DTMF_AUTO_INFO:
 		if (!media || !media->rtp || (ast_rtp_instance_dtmf_mode_get(media->rtp) == AST_RTP_DTMF_MODE_NONE)) {
-			return -1;
+			return 0;
 		}
 		ast_rtp_instance_dtmf_begin(media->rtp, digit);
 		break;

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11235
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I9e348db15be0ece827eba8135c0591c53da8c802
Gerrit-Change-Number: 11235
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Salah Ahmed <txrubel at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190405/353cb93a/attachment.html>