[Asterisk-code-review] bridge_softmix: use a float type to store the internal REMB bitrate (...asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11193 )

Change subject: bridge_softmix: use a float type to store the internal REMB bitrate
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/11193/2/bridges/bridge_softmix.c 
File bridges/bridge_softmix.c:

https://gerrit.asterisk.org/#/c/11193/2/bridges/bridge_softmix.c@1409 
PS2, Line 1409: 	exp = exp > 18 ? exp - 18 : 0;
I don't think this is correct but i could be incorrect.  How about some examples?


https://gerrit.asterisk.org/#/c/11193/2/res/res_remb_modifier.c 
File res/res_remb_modifier.c:

https://gerrit.asterisk.org/#/c/11193/2/res/res_remb_modifier.c@108 
PS2, Line 108: 	exp = exp > 18 ? exp - 18 : 0;
Again.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11193
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ice00fdd16693b16b41230664be5d9f0e465b239e
Gerrit-Change-Number: 11193
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 02 Apr 2019 15:26:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190402/1c7208b5/attachment-0001.html>