[Asterisk-code-review] jansson: Backport fixes to bundled, use json vsprintf if ava... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10252 )

Change subject: jansson: Backport fixes to bundled, use json_vsprintf if available.
......................................................................


Patch Set 1:

(1 comment)

Otherwise looks fine.

https://gerrit.asterisk.org/#/c/10252/1/main/json.c
File main/json.c:

https://gerrit.asterisk.org/#/c/10252/1/main/json.c@483
PS1, Line 483: #if defined(HAVE_JANSSON_BUNDLED) || JANSSON_MAJOR_VERSION > 2 || JANSSON_MINOR_VERSION > 11
> json_pack was a new feature to 2.0.  So it was never possible to compile Asterisk using jansson 1.x. […]
Then it would be nice to have a comment about that since the conditional just looks wrong if you don't know that.



-- 
To view, visit https://gerrit.asterisk.org/10252
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I7522e462d2a52f53010ffa1e7d705c666ec35539
Gerrit-Change-Number: 10252
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 24 Sep 2018 22:49:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180924/c5ef08aa/attachment.html>