[Asterisk-code-review] json: Take advantage of new API's. (asterisk[16])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10194 )

Change subject: json: Take advantage of new API's.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/10194/2/main/json.c
File main/json.c:

https://gerrit.asterisk.org/#/c/10194/2/main/json.c@299
PS2, Line 299: 	return (struct ast_json *)json_vsprintf(format, args);
The 2.11 version of json_vsprintf uses va_copy but never calls va_end so I think changes to this function need to be reverted.

jansson 'master' has a fix for this.  Once released I'll likely add conditional code to use json_vsprintf for >=2.12 since it reduces the number of allocations and avoids a string copy.



-- 
To view, visit https://gerrit.asterisk.org/10194
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: I8382d28d7d83ee0ce13334e51ae45dbc0bdaef48
Gerrit-Change-Number: 10194
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 24 Sep 2018 04:34:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180923/b5f8c26a/attachment.html>