[Asterisk-code-review] chan sip: SipNotify on Chan Sip vi AMI behave different to CLI (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10176 )

Change subject: chan_sip: SipNotify on Chan_Sip vi AMI behave different to CLI
......................................................................


Patch Set 2: Code-Review+1

There is a comment in sip_send_mwi_to_peer():

/* If we don't set the socket type to 0, then create_addr_from_peer will fail immediately if the peer
 * uses any transport other than UDP. We set the type to 0 here and then let create_addr_from_peer copy
 * the peer's socket information to the sip_pvt we just allocated
 */
set_socket_transport(&p->socket, 0);
if (create_addr_from_peer(p, peer)) {
}

As best I can figure, this gives the best clue to what the create_addr() newdialog parameter is supposed to do.  That and I don't understand why any caller would want to pass nonzero for the newdialog parameter even though some of those callers seem to setup the p->socket.type.  Maybe they expect that a peer won't be found so the newdialog parameter won't be used.


This needs to be cherry-picked to 15, 16, and master.


-- 
To view, visit https://gerrit.asterisk.org/10176
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43315aba1f2c14ba077b52d8c5b00be0006656e
Gerrit-Change-Number: 10176
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Katzmann <peter.katzmann at edag.de>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 18 Sep 2018 21:58:36 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180918/0e7b7d1b/attachment.html>