[Asterisk-code-review] pjsip/dtmf info fallback: Test fails when connected line upd... (testsuite[master])

Jenkins2 asteriskteam at digium.com
Wed Sep 12 09:23:02 CDT 2018


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/10086 )

Change subject: pjsip/dtmf_info_fallback: Test fails when connected line update is sent
......................................................................

pjsip/dtmf_info_fallback: Test fails when connected line update is sent

If the timing was right then Asterisk would send an unexpected connected line
INVITE udpate, which would then fail the test.

This patch disables 'send_rpid' since it's not needed for the test. Thus making
it so the connected line update will never be sent.

Change-Id: I1e11131e0200b073c22c9fe44bef49ba56d5d4e6
---
M tests/channels/pjsip/dtmf_info_fallback/configs/ast1/pjsip.conf
M tests/channels/pjsip/dtmf_info_fallback/test-config.yaml
2 files changed, 7 insertions(+), 28 deletions(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/tests/channels/pjsip/dtmf_info_fallback/configs/ast1/pjsip.conf b/tests/channels/pjsip/dtmf_info_fallback/configs/ast1/pjsip.conf
index 74719a5..344e2a5 100644
--- a/tests/channels/pjsip/dtmf_info_fallback/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/dtmf_info_fallback/configs/ast1/pjsip.conf
@@ -7,41 +7,19 @@
 protocol = udp
 bind = 0.0.0.0:5060
 
-[alice]
+[endpoint](!)
 type = endpoint
-context = default
 dtmf_mode = auto_info
-disallow = all
-allow = alaw
-allow = ulaw
-allow = g729
-allow = h263p
-allow = h264
+allow = !all,ulaw
 direct_media = no
-send_rpid = yes
-sdp_session = session
-t38_udptl = yes
-t38_udptl_ec = redundancy
+
+[alice](endpoint)
 
 [bob]
 type = aor
-max_contacts=1
+max_contacts = 1
 contact = sip:127.0.0.1:5062
 
-[bob]
-type = endpoint
-context = default
-dtmf_mode = auto_info
-disallow = all
-allow = alaw
-allow = ulaw
-allow = g729
-allow = h263p
-allow = h264
-direct_media = no
-send_rpid = yes
-sdp_session = session
+[bob](endpoint)
 aors = bob
-t38_udptl = yes
-t38_udptl_ec = redundancy
 
diff --git a/tests/channels/pjsip/dtmf_info_fallback/test-config.yaml b/tests/channels/pjsip/dtmf_info_fallback/test-config.yaml
index 512c16e..dee9a0c 100644
--- a/tests/channels/pjsip/dtmf_info_fallback/test-config.yaml
+++ b/tests/channels/pjsip/dtmf_info_fallback/test-config.yaml
@@ -7,6 +7,7 @@
     dependencies:
         - app : 'sipp'
         - asterisk : 'res_pjsip'
+        - asterisk : 'app_dial'
         - custom : 'rawsocket'
     tags:
         - pjsip

-- 
To view, visit https://gerrit.asterisk.org/10086
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e11131e0200b073c22c9fe44bef49ba56d5d4e6
Gerrit-Change-Number: 10086
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180912/56860dc2/attachment.html>


More information about the asterisk-code-review mailing list