[Asterisk-code-review] app dial: set the comment for OPT ARG ANNOUNCE to really wha... (asterisk[15])

George Joseph asteriskteam at digium.com
Wed Sep 5 11:00:33 CDT 2018


George Joseph has submitted this change and it was merged. ( https://gerrit.asterisk.org/10042 )

Change subject: app_dial: set the comment for OPT_ARG_ANNOUNCE to really what is done
......................................................................

app_dial: set the comment for OPT_ARG_ANNOUNCE to really what is done

Change-Id: I08f88adb09f7e5813f37e70fecd787468cdb32c8
---
M apps/app_dial.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved
  George Joseph: Approved for Submit



diff --git a/apps/app_dial.c b/apps/app_dial.c
index d78ba53..2dea5d3 100644
--- a/apps/app_dial.c
+++ b/apps/app_dial.c
@@ -2848,7 +2848,7 @@
 			chans[0] = chan;
 			chans[1] = peer;
 
-			/* we need to stream the announcement while monitoring the caller for a hangup */
+			/* we need to stream the announcement to the called party when the OPT_ARG_ANNOUNCE (-A) is setted */
 
 			/* stream the file */
 			res = ast_streamfile(peer, opt_args[OPT_ARG_ANNOUNCE], ast_channel_language(peer));

-- 
To view, visit https://gerrit.asterisk.org/10042
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: merged
Gerrit-Change-Id: I08f88adb09f7e5813f37e70fecd787468cdb32c8
Gerrit-Change-Number: 10042
Gerrit-PatchSet: 1
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180905/b8c51fab/attachment.html>


More information about the asterisk-code-review mailing list