[Asterisk-code-review] testsuite: fix rewrite contact tests (testsuite[13])

[George Joseph]

George Joseph has uploaded a new patch set (#3) to the change originally created by Torrey Searle. ( https://gerrit.asterisk.org/10528 )

Change subject: testsuite: fix rewrite_contact tests
......................................................................

testsuite: fix rewrite_contact tests

The current rewrite_contact tests put the correct source ip in the
headers expected to be rewritten, thus the header re-write has no
effect & the test would pass regardless if rewrite_contact is enabled.
To fix this, the tests have been updated to have a bogus ip in the
route header & ensure that it is either modified, (or remains the same)

Tests were also added to validate the other half the nat logic, where
contact should be updated in the case no route set is present

Change-Id: Ic3974170dfc3bb878b663359c459a08f9674d9a6
---
A tests/channels/pjsip/nat/rewrite_contact/contact_request/configs/ast1/extensions.conf
A tests/channels/pjsip/nat/rewrite_contact/contact_request/configs/ast1/pjsip.conf
A tests/channels/pjsip/nat/rewrite_contact/contact_request/sipp/uac-route-set.xml
A tests/channels/pjsip/nat/rewrite_contact/contact_request/test-config.yaml
A tests/channels/pjsip/nat/rewrite_contact/contact_response/configs/ast1/extensions.conf
A tests/channels/pjsip/nat/rewrite_contact/contact_response/configs/ast1/pjsip.conf
A tests/channels/pjsip/nat/rewrite_contact/contact_response/sipp/uas-route-set.xml
A tests/channels/pjsip/nat/rewrite_contact/contact_response/test-config.yaml
M tests/channels/pjsip/nat/rewrite_contact/route_set_request/sipp/uac-route-set.xml
M tests/channels/pjsip/nat/rewrite_contact/route_set_response/sipp/uas-route-set.xml
M tests/channels/pjsip/nat/rewrite_contact/tests.yaml
11 files changed, 302 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/28/10528/3
-- 
To view, visit https://gerrit.asterisk.org/10528
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic3974170dfc3bb878b663359c459a08f9674d9a6
Gerrit-Change-Number: 10528
Gerrit-PatchSet: 3
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181031/f6b1f134/attachment.html>