[Asterisk-code-review] app queue: Revert broken queue channel reference patch (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10523 )

Change subject: app_queue: Revert broken queue channel reference patch
......................................................................


Patch Set 3: Code-Review-1

I think to actually fix the underlying problem what needs to happen is that queue_stasis_data_alloc also places a datastore (like the masquerade datastore in res/res_stasis.c) on the member and the caller channel. A callback would then be invoked when a masquerade happens with the new channel, allowing the old one in queue_stasis_data_alloc to be unreferenced and the new one to take its place - so that it follows the correct channel again.

This should ensure the wrong channel does not stick around, and also ensure as originally intended that the correct channel remains when making the stasis messages.


-- 
To view, visit https://gerrit.asterisk.org/10523
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: I37334ea184ebb56e54471496b82937d4927815a0
Gerrit-Change-Number: 10523
Gerrit-PatchSet: 3
Gerrit-Owner: lvl <digium at lvlconsultancy.nl>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 26 Oct 2018 13:14:18 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181026/eb48d2a7/attachment.html>