[Asterisk-code-review] app queue: Revert broken queue channel reference patch (asterisk[16])

Sean Bright asteriskteam at digium.com
Mon Oct 22 08:14:08 CDT 2018


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/10523 )

Change subject: app_queue: Revert broken queue channel reference patch
......................................................................


Patch Set 2: Code-Review-1

(6 comments)

https://gerrit.asterisk.org/#/c/10523/2/apps/app_queue.c
File apps/app_queue.c:

https://gerrit.asterisk.org/#/c/10523/2/apps/app_queue.c@6193
PS2, Line 6193: 	}
              : 	else {
Coding guidelines: Should be '} else {' (all on same line)


https://gerrit.asterisk.org/#/c/10523/2/apps/app_queue.c@6253
PS2, Line 6253: 	
Red blob (trailing whitespace)


https://gerrit.asterisk.org/#/c/10523/2/apps/app_queue.c@6256
PS2, Line 6256: 	}
              : 	else {
Coding guidelines: Should be '} else {' (all on same line)


https://gerrit.asterisk.org/#/c/10523/2/apps/app_queue.c@6260
PS2, Line 6260: 	
Red blob


https://gerrit.asterisk.org/#/c/10523/2/apps/app_queue.c@6471
PS2, Line 6471: 	}
              : 	else {
Coding guidelines: Should be '} else {' (all on same line)


https://gerrit.asterisk.org/#/c/10523/2/apps/app_queue.c@6475
PS2, Line 6475: 	
Red blob



-- 
To view, visit https://gerrit.asterisk.org/10523
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: I37334ea184ebb56e54471496b82937d4927815a0
Gerrit-Change-Number: 10523
Gerrit-PatchSet: 2
Gerrit-Owner: lvl <digium at lvlconsultancy.nl>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 22 Oct 2018 13:14:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181022/b219c934/attachment-0001.html>


More information about the asterisk-code-review mailing list