[Asterisk-code-review] astobj2: Eliminate legacy container allocation macros. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10503 )

Change subject: astobj2: Eliminate legacy container allocation macros.
......................................................................


Patch Set 2: Code-Review-1

(6 comments)

https://gerrit.asterisk.org/#/c/10503/2/main/pbx.c
File main/pbx.c:

https://gerrit.asterisk.org/#/c/10503/2/main/pbx.c@3057
PS2, Line 3057: 	return ao2_container_alloc_hash(AO2_ALLOC_OPT_LOCK_NOLOCK, 0, 1, NULL, NULL, NULL);
This should be a list container since there is only one bucket.


https://gerrit.asterisk.org/#/c/10503/2/main/pickup.c
File main/pickup.c:

https://gerrit.asterisk.org/#/c/10503/2/main/pickup.c@138
PS2, Line 138: 	candidates = ao2_container_alloc_hash(AO2_ALLOC_OPT_LOCK_NOLOCK, 0, 1, NULL, NULL, NULL);
This should be a list container since there is only one bucket.


https://gerrit.asterisk.org/#/c/10503/2/main/sorcery.c
File main/sorcery.c:

https://gerrit.asterisk.org/#/c/10503/2/main/sorcery.c@1795
PS2, Line 1795: 		object = ao2_container_alloc_hash(AO2_ALLOC_OPT_LOCK_NOLOCK, 0, 1,
This should be a list container since there is only one bucket.


https://gerrit.asterisk.org/#/c/10503/2/main/sorcery.c@1845
PS2, Line 1845: 	objects = ao2_container_alloc_hash(AO2_ALLOC_OPT_LOCK_NOLOCK, 0, 1, NULL, NULL, NULL);
This should be a list container since there is only one bucket.


https://gerrit.asterisk.org/#/c/10503/2/main/sorcery.c@1880
PS2, Line 1880: 	objects = ao2_container_alloc_hash(AO2_ALLOC_OPT_LOCK_NOLOCK, 0, 1, NULL, NULL, NULL);
This should be a list container since there is only one bucket.


https://gerrit.asterisk.org/#/c/10503/2/tests/test_astobj2.c
File tests/test_astobj2.c:

https://gerrit.asterisk.org/#/c/10503/2/tests/test_astobj2.c@459
PS2, Line 459: 	c2 = ao2_t_container_alloc_hash(AO2_ALLOC_OPT_LOCK_MUTEX, 0, 1,
This should be a list container since there is only one bucket.



-- 
To view, visit https://gerrit.asterisk.org/10503
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a26258b5bf3deb081aaeed11a0baa175c933c7a
Gerrit-Change-Number: 10503
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 19 Oct 2018 21:26:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181019/6dd6aa0f/attachment.html>