[Asterisk-code-review] stasis: Add internal filtering of messages. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10479 )

Change subject: stasis: Add internal filtering of messages.
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/10479/4/main/stasis.c
File main/stasis.c:

https://gerrit.asterisk.org/#/c/10479/4/main/stasis.c@643
PS4, Line 643: 	ast_assert(type != NULL);
> Should we have type == NULL cause accepted_message_types to be cleared (AST_VECTOR_RESET)? […]
I think for now I'd rather have it be explicit. If we get to using this and we think it'll be useful, we can certainly change it. My thinking originally of getting this in was something like AMI being smart about what message types bubble up to it based on the classes of connections and such. Whether that'll happen, dunno, but it was easy to add this.



-- 
To view, visit https://gerrit.asterisk.org/10479
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99bee23895baa0a117985d51683f7963b77aa190
Gerrit-Change-Number: 10479
Gerrit-PatchSet: 4
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 18 Oct 2018 13:41:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181018/617ad428/attachment.html>