[Asterisk-code-review] threadpool: Eliminate pointless AO2 usage. (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Fri Oct 12 17:59:55 CDT 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10470 )

Change subject: threadpool: Eliminate pointless AO2 usage.
......................................................................


Patch Set 1:

I would rather leave these items as ao2 objects.  They certainly don't need the lock and you have identified some other improvements.  

The beauty of keeping them ao2 objects is you don't need to worry about calling an appropriate destructor function if there even is one when the ref is decremented.


-- 
To view, visit https://gerrit.asterisk.org/10470
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I2204d2615d9d952670fcb48e0a9c0dd1a6ba5036
Gerrit-Change-Number: 10470
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 12 Oct 2018 22:59:55 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181012/c83c90b8/attachment.html>


More information about the asterisk-code-review mailing list