[Asterisk-code-review] app dial/queue/followme: 'I' options to block initial update... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10286 )

Change subject: app_dial/queue/followme: 'I' options to block initial updates in both directions
......................................................................


Patch Set 3:

> > You can use the pjsip endpoint callerid_tag option string to
 > > indicate which tenant the
 > > endpoint represents.  The interception routine can compare the
 > > channel's callerid tag
 > > with the updated connected line's tag.  (You could compare the
 > > connected line tag with
 > > a parameter set on the interception routine's arguments instead
 > of
 > > the callerid tag.)
 > 
 > I think I found a bug with CONNECTEDLINE(tag) on attended transfer
 > and need a help to fix it.
 > 
 > Alice's tag is "Alice".
 > Bob's tag is empty.
 > Charlie's tag is "Charlie".
 > Alice calls Bob and then does attended transfer to Charlie.
 > When Alice hangs up on the interception routine on the Charlie
 > channel
 > the CONNECTEDLINE(tag) is "Alice", but should be empty.
 > 
 > If Bob's tag is "Bob" then on the Charlie channel the 
 > CONNECTEDLINE(tag) is "Bob".
 > 
 > I think somewhere the destination tag is not set/reset
 > if source tag is empty.
 > 
 > Could you, please, help me find it.

Connected line updates can be partial updates.  One of the criteria for
sending a partial update is a NULL string.  NULL strings do not
become part of a connected line update so the other end merges what it
already has with the information passed in a partial update.

Channel drivers don't necessarily pass the full party id information
at once because the other end didn't pass all the information.  For
example ISDN passes the number and then follows up with the name if 
available.  Even SIP doesn't always pass a name.


-- 
To view, visit https://gerrit.asterisk.org/10286
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ce9e151a2220ce9e95aa66666933cfb9e2a4a01
Gerrit-Change-Number: 10286
Gerrit-PatchSet: 3
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 09 Oct 2018 22:52:01 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181009/c589d963/attachment.html>