[Asterisk-code-review] res pjsip sdp rtp: Control endpoints media address use per c... (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/10431 )

Change subject: res_pjsip_sdp_rtp: Control endpoints media_address use per call basis
......................................................................


Patch Set 4: Code-Review-1

(6 comments)

Coding guidelines: https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines#CodingGuidelines-Codeformatting

https://gerrit.asterisk.org/#/c/10431/4/res/res_pjsip_sdp_rtp.c
File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/#/c/10431/4/res/res_pjsip_sdp_rtp.c@1249
PS4, Line 1249:  
Remove the space before 'session->channel...'


https://gerrit.asterisk.org/#/c/10431/4/res/res_pjsip_sdp_rtp.c@1250
PS4, Line 1250: if(
Add a space between 'if' and '('


https://gerrit.asterisk.org/#/c/10431/4/res/res_pjsip_sdp_rtp.c@1251
PS4, Line 1251: if(
Add a space between 'if' and '('


https://gerrit.asterisk.org/#/c/10431/4/res/res_pjsip_sdp_rtp.c@1251
PS4, Line 1251: strcmp("yes", use_media_address) == 0
Change this to '!strcmp(...)' instead of comparing with 0

(I don't particularly like this, but that is how it is done in most other places in the code base)


https://gerrit.asterisk.org/#/c/10431/4/res/res_pjsip_sdp_rtp.c@1253
PS4, Line 1253: if(
Add a space between 'if' and '('


https://gerrit.asterisk.org/#/c/10431/4/res/res_pjsip_sdp_rtp.c@1253
PS4, Line 1253: strcmp("no", use_media_address) == 0
Change this to '!strcmp(...)' instead of comparing with 0



-- 
To view, visit https://gerrit.asterisk.org/10431
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I852adbee9f8b034ec332fbe4e1b6692cb2939518
Gerrit-Change-Number: 10431
Gerrit-PatchSet: 4
Gerrit-Owner: Salah Ahmed <txrubel at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 05 Oct 2018 13:37:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181005/14130e44/attachment.html>