[Asterisk-code-review] app dial/queue/followme: 'I' options to block initial update... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10286 )

Change subject: app_dial/queue/followme: 'I' options to block initial updates in both directions
......................................................................


Patch Set 3:

> > You can use the pjsip endpoint callerid_tag option string to
 > > indicate which tenant the
 > > endpoint represents.  The interception routine can compare the
 > > channel's callerid tag
 > > with the updated connected line's tag.  (You could compare the
 > > connected line tag with
 > > a parameter set on the interception routine's arguments instead
 > of
 > > the callerid tag.)
 > > If they match you know it is one tenant member talking with
 > > another.  If they don't
 > > match then you can use the fixed "public" identity of the
 > connected
 > > line tenant.
 > 
 > The callerid_tag... it's an interesting thing.
 > If I'm correct there is only one way to get the channel caller id
 > tag
 > inside the interception route using
 > ${PJSIP_ENDPOINT(${CHANNEL(endpoint)},callerid_tag)}
 > 
 > What do you think if the callerid_tag can be retrieved by the
 > CHANNEL function
 > directly using ast_sip_session.id.tag
 > like
 > ${CHANNEL(pjsip,callerid_tag)}) or ${CHANNEL(callerid_tag)})
 > 
 > If you agree I can do a new patch which will add this to
 > channels/pjsip/dialplan_functions.c

There is no need for a patch.  The endpoint's configured
callerid_tag string is set in the channel's CALLERID(tag) whenever
a PJSIP channel is created.  Other channel drivers should do
the same for their equivalent callerid tag setting.  That means
you can get the tag string using CALLERID(tag) when the channel
comes into asterisk.  And for the outgoing channel, you can get
the tag using CALLERID(tag) in the predial handler.

Unless you set the CALLERID(tag) in your dialplan to something else,
that string should stay there.


-- 
To view, visit https://gerrit.asterisk.org/10286
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ce9e151a2220ce9e95aa66666933cfb9e2a4a01
Gerrit-Change-Number: 10286
Gerrit-PatchSet: 3
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 04 Oct 2018 23:00:13 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181004/85e3c019/attachment-0001.html>