[Asterisk-code-review] core/frame: generate correct T.140 payload in ast sendtext d... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10421 )

Change subject: core/frame: generate correct T.140 payload in ast_sendtext_data()
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/10421/1/main/channel.c
File main/channel.c:

https://gerrit.asterisk.org/#/c/10421/1/main/channel.c@4908
PS1, Line 4908: 		size_t body_len = strlen(body);
Please add a comment note that the frame length cannot include the null terminator.  Otherwise, it might get "fixed" again.



-- 
To view, visit https://gerrit.asterisk.org/10421
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ab1b9ed1e21683b2b667ea0a59d9aba3c77dd96
Gerrit-Change-Number: 10421
Gerrit-PatchSet: 1
Gerrit-Owner: Emmanuel BUU <emmanuel.buu at ives.fr>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 03 Oct 2018 22:50:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181003/21d35577/attachment-0001.html>