[Asterisk-code-review] res statsd.c: Made use defaults if the statsd.conf file does... (asterisk[16])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10385 )

Change subject: res_statsd.c: Made use defaults if the statsd.conf file does not exist.
......................................................................


Patch Set 1: Code-Review+1

I think the ability to tell loader.c that the module is disabled will still be helpful but this is also a good idea.

As for declining vs not declining I think you've hit the right balance.  It's reasonable to decline in response to system errors, if we can't allocate ACO structures then other stuff will likely fail anyways.

One thing I wish that we could decline upon invalid statsd.conf but succeed for missing statsd.conf and system errors.  I haven't looked into what it would take to get ACO to support a flag causing missing config to initialize defaults and return success.  Obviously it would be a change of behavior but maybe that's the way ACO should just work?


-- 
To view, visit https://gerrit.asterisk.org/10385
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: If1068a582ec54ab7fb437265cb5370a97a825737
Gerrit-Change-Number: 10385
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Comment-Date: Wed, 03 Oct 2018 08:43:18 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181003/f14161b6/attachment.html>