[Asterisk-code-review] app queue: Revert broken queue channel reference patch (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10523 )

Change subject: app_queue: Revert broken queue channel reference patch
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.asterisk.org/#/c/10523/6/apps/app_queue.c
File apps/app_queue.c:

https://gerrit.asterisk.org/#/c/10523/6/apps/app_queue.c@2189
PS6, Line 2189: 		ast_log(LOG_WARNING, "Empty caller_snapshot; sending incomplete event\n");
> That is true. […]
To an end user it can, yes. If you have multiple queues and you see that message all you can say is "well - one of them went wrong in some way". When writing log messages that are viewed by others (specifically non-developers) it's always important to approach it from a user perspective who has no idea of the implementation detail. They just saw that message. If it's not useful to them but is useful to a developer then debug is appropriate. If it's still valuable to a user then making it more useful would be better.



-- 
To view, visit https://gerrit.asterisk.org/10523
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: I37334ea184ebb56e54471496b82937d4927815a0
Gerrit-Change-Number: 10523
Gerrit-PatchSet: 6
Gerrit-Owner: lvl <digium at lvlconsultancy.nl>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: lvl <digium at lvlconsultancy.nl>
Gerrit-Comment-Date: Tue, 27 Nov 2018 12:49:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181127/239ada4c/attachment.html>