[Asterisk-code-review] res pjsip: Patch for res pjsip * module load/reload crash (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10617 )

Change subject: res_pjsip: Patch for res_pjsip_* module load/reload crash
......................................................................


Patch Set 7: Code-Review-1

(5 comments)

https://gerrit.asterisk.org/#/c/10617/7/include/asterisk/res_pjsip_session.h
File include/asterisk/res_pjsip_session.h:

https://gerrit.asterisk.org/#/c/10617/7/include/asterisk/res_pjsip_session.h@585
PS7, Line 585:  * \param module Referenced module
Document that it is safe for it to be NULL


https://gerrit.asterisk.org/#/c/10617/7/res/res_pjsip/pjsip_session.c
File res/res_pjsip/pjsip_session.c:

https://gerrit.asterisk.org/#/c/10617/7/res/res_pjsip/pjsip_session.c@41
PS7, Line 41: 	if(!supplement) {
            : 		return;
            : 	}
This should be an assert if you do want to add a check in.


https://gerrit.asterisk.org/#/c/10617/7/res/res_pjsip/pjsip_session.c@45
PS7, Line 45: 	if (module) {
            : 		supplement->module = module;
            : 	}
There's no need for this if, it can always be done.


https://gerrit.asterisk.org/#/c/10617/7/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/10617/7/res/res_pjsip_session.c@2249
PS7, Line 2249: 	
Remove added red


https://gerrit.asterisk.org/#/c/10617/7/res/res_pjsip_session.c@3320
PS7, Line 3320: 	ast_log(LOG_DEBUG, "Fired handle_session_begin.\n");
I don't think these debug messages would be useful after implementing this change.



-- 
To view, visit https://gerrit.asterisk.org/10617
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b82be3a75d702cf1933d8d1417f44aa10ad1029
Gerrit-Change-Number: 10617
Gerrit-PatchSet: 7
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Thu, 15 Nov 2018 13:39:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181115/71cefe3c/attachment-0001.html>