[Asterisk-code-review] pjsip: New function PJSIP PARSE URI to parse URI and return ... (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/10577 )

Change subject: pjsip: New function PJSIP_PARSE_URI to parse URI and return part of URI
......................................................................


Patch Set 3:

> I understand that, but PJLIB functions which allocate memory from a
 > pool and perform actions should be done within a PJLIB registered
 > thread. I believe we may disable the warning, but PJSIP did yell at
 > you if you did not follow this boundary in the past and the
 > behavior drifts into undefined territory - as they could do
 > something in the future which breaks it if you do not do it on a
 > PJLIB registered thread. It is best to respect the boundary.

My bad.

https://www.pjsip.org/pjsip/docs/html/group__PJSIP__ENDPT.htm#ga933050e06b1bb573ade79a4fcb5ea5d6
"This function, like all other endpoint functions, is thread safe."

I thought that "thread safe" means this function could be called on any thread even if the thread is not PJSIP registered.


-- 
To view, visit https://gerrit.asterisk.org/10577
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d828fb87f6803b6c1152bb7b44835f027bb9d5a
Gerrit-Change-Number: 10577
Gerrit-PatchSet: 3
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 05 Nov 2018 18:28:53 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181105/8d222c00/attachment.html>