[Asterisk-code-review] Update app/voicemail tests to use chan pjsip instead of chan... (testsuite[certified/13.21])

[George Joseph]

Hello Kevin Harwell, Joshua Colp, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/9041

to look at the new patch set (#3).

Change subject: Update app/voicemail tests to use chan_pjsip instead of chan_sip
......................................................................

Update app/voicemail tests to use chan_pjsip instead of chan_sip

This required a small change to the voicemail.py library but otherwise
sip_to_pjsip.py took care of converting all of the sip.conf files.
Then it was just a matter of adjusting the dial strings in the run-test
files.

Change-Id: I2722aa6b670e500063a497371f7a7749d59e13e5
---
M lib/python/asterisk/voicemail.py
M tests/apps/dial/dial_answer/configs/ast1/extensions.conf
A tests/apps/dial/dial_answer/configs/ast1/pjsip.conf
D tests/apps/dial/dial_answer/configs/ast1/sip.conf
M tests/apps/dial/dial_answer/test-config.yaml
M tests/apps/dial/dial_busy/configs/ast1/extensions.conf
A tests/apps/dial/dial_busy/configs/ast1/pjsip.conf
D tests/apps/dial/dial_busy/configs/ast1/sip.conf
M tests/apps/dial/dial_busy/test-config.yaml
M tests/apps/dial/dial_congestion/configs/ast1/extensions.conf
A tests/apps/dial/dial_congestion/configs/ast1/pjsip.conf
D tests/apps/dial/dial_congestion/configs/ast1/sip.conf
M tests/apps/dial/dial_congestion/test-config.yaml
M tests/apps/dial/dial_dtmf_hangup_cancel/configs/ast1/extensions.conf
A tests/apps/dial/dial_dtmf_hangup_cancel/configs/ast1/pjsip.conf
D tests/apps/dial/dial_dtmf_hangup_cancel/configs/ast1/sip.conf
M tests/apps/dial/dial_dtmf_hangup_cancel/test-config.yaml
M tests/apps/dial/dial_hangup/configs/ast1/extensions.conf
A tests/apps/dial/dial_hangup/configs/ast1/pjsip.conf
D tests/apps/dial/dial_hangup/configs/ast1/sip.conf
M tests/apps/dial/dial_hangup/test-config.yaml
M tests/apps/dial/dial_no_answer/configs/ast1/extensions.conf
A tests/apps/dial/dial_no_answer/configs/ast1/pjsip.conf
D tests/apps/dial/dial_no_answer/configs/ast1/sip.conf
M tests/apps/dial/dial_no_answer/test-config.yaml
M tests/apps/dial/dial_parallel/dial_parallel_all_busy/configs/ast1/extensions.conf
A tests/apps/dial/dial_parallel/dial_parallel_all_busy/configs/ast1/pjsip.conf
D tests/apps/dial/dial_parallel/dial_parallel_all_busy/configs/ast1/sip.conf
M tests/apps/dial/dial_parallel/dial_parallel_all_busy/test-config.yaml
M tests/apps/dial/dial_parallel/dial_parallel_all_cancel/configs/ast1/extensions.conf
A tests/apps/dial/dial_parallel/dial_parallel_all_cancel/configs/ast1/pjsip.conf
D tests/apps/dial/dial_parallel/dial_parallel_all_cancel/configs/ast1/sip.conf
M tests/apps/dial/dial_parallel/dial_parallel_all_cancel/test-config.yaml
M tests/apps/dial/dial_parallel/dial_parallel_all_congestion/configs/ast1/extensions.conf
A tests/apps/dial/dial_parallel/dial_parallel_all_congestion/configs/ast1/pjsip.conf
D tests/apps/dial/dial_parallel/dial_parallel_all_congestion/configs/ast1/sip.conf
M tests/apps/dial/dial_parallel/dial_parallel_all_congestion/test-config.yaml
M tests/apps/dial/dial_parallel/dial_parallel_all_no_answer/configs/ast1/extensions.conf
A tests/apps/dial/dial_parallel/dial_parallel_all_no_answer/configs/ast1/pjsip.conf
D tests/apps/dial/dial_parallel/dial_parallel_all_no_answer/configs/ast1/sip.conf
M tests/apps/dial/dial_parallel/dial_parallel_all_no_answer/test-config.yaml
M tests/apps/dial/dial_parallel/dial_parallel_all_unavail/configs/ast1/extensions.conf
A tests/apps/dial/dial_parallel/dial_parallel_all_unavail/configs/ast1/pjsip.conf
D tests/apps/dial/dial_parallel/dial_parallel_all_unavail/configs/ast1/sip.conf
M tests/apps/dial/dial_parallel/dial_parallel_all_unavail/test-config.yaml
M tests/apps/dial/dial_parallel/dial_parallel_answer_cancel/configs/ast1/extensions.conf
A tests/apps/dial/dial_parallel/dial_parallel_answer_cancel/configs/ast1/pjsip.conf
D tests/apps/dial/dial_parallel/dial_parallel_answer_cancel/configs/ast1/sip.conf
M tests/apps/dial/dial_parallel/dial_parallel_answer_cancel/test-config.yaml
M tests/apps/dial/dial_parallel/dial_parallel_single_busy/configs/ast1/extensions.conf
A tests/apps/dial/dial_parallel/dial_parallel_single_busy/configs/ast1/pjsip.conf
D tests/apps/dial/dial_parallel/dial_parallel_single_busy/configs/ast1/sip.conf
M tests/apps/dial/dial_parallel/dial_parallel_single_busy/test-config.yaml
M tests/apps/dial/dial_parallel/dial_parallel_single_congestion/configs/ast1/extensions.conf
A tests/apps/dial/dial_parallel/dial_parallel_single_congestion/configs/ast1/pjsip.conf
D tests/apps/dial/dial_parallel/dial_parallel_single_congestion/configs/ast1/sip.conf
M tests/apps/dial/dial_parallel/dial_parallel_single_congestion/test-config.yaml
M tests/apps/dial/dial_parallel/dial_parallel_single_no_answer/configs/ast1/extensions.conf
A tests/apps/dial/dial_parallel/dial_parallel_single_no_answer/configs/ast1/pjsip.conf
D tests/apps/dial/dial_parallel/dial_parallel_single_no_answer/configs/ast1/sip.conf
M tests/apps/dial/dial_parallel/dial_parallel_single_no_answer/test-config.yaml
M tests/apps/dial/dial_parallel/dial_parallel_single_unavail/configs/ast1/extensions.conf
A tests/apps/dial/dial_parallel/dial_parallel_single_unavail/configs/ast1/pjsip.conf
D tests/apps/dial/dial_parallel/dial_parallel_single_unavail/configs/ast1/sip.conf
M tests/apps/dial/dial_parallel/dial_parallel_single_unavail/test-config.yaml
M tests/apps/dial/dial_timeout/configs/ast1/extensions.conf
A tests/apps/dial/dial_timeout/configs/ast1/pjsip.conf
D tests/apps/dial/dial_timeout/configs/ast1/sip.conf
M tests/apps/dial/dial_timeout/test-config.yaml
M tests/apps/dial/dial_unavail/configs/ast1/extensions.conf
A tests/apps/dial/dial_unavail/configs/ast1/pjsip.conf
D tests/apps/dial/dial_unavail/configs/ast1/sip.conf
M tests/apps/dial/dial_unavail/test-config.yaml
A tests/apps/voicemail/authenticate_extensions/configs/ast1/pjsip.conf
D tests/apps/voicemail/authenticate_extensions/configs/ast1/sip.conf
A tests/apps/voicemail/authenticate_extensions/configs/ast2/pjsip.conf
D tests/apps/voicemail/authenticate_extensions/configs/ast2/sip.conf
M tests/apps/voicemail/authenticate_extensions/run-test
M tests/apps/voicemail/authenticate_extensions/test-config.yaml
A tests/apps/voicemail/authenticate_invalid_mailbox/configs/ast1/pjsip.conf
D tests/apps/voicemail/authenticate_invalid_mailbox/configs/ast1/sip.conf
A tests/apps/voicemail/authenticate_invalid_mailbox/configs/ast2/pjsip.conf
D tests/apps/voicemail/authenticate_invalid_mailbox/configs/ast2/sip.conf
M tests/apps/voicemail/authenticate_invalid_mailbox/run-test
M tests/apps/voicemail/authenticate_invalid_mailbox/test-config.yaml
A tests/apps/voicemail/authenticate_invalid_password/configs/ast1/pjsip.conf
D tests/apps/voicemail/authenticate_invalid_password/configs/ast1/sip.conf
A tests/apps/voicemail/authenticate_invalid_password/configs/ast2/pjsip.conf
D tests/apps/voicemail/authenticate_invalid_password/configs/ast2/sip.conf
M tests/apps/voicemail/authenticate_invalid_password/run-test
M tests/apps/voicemail/authenticate_invalid_password/test-config.yaml
A tests/apps/voicemail/authenticate_nominal/configs/ast1/pjsip.conf
D tests/apps/voicemail/authenticate_nominal/configs/ast1/sip.conf
A tests/apps/voicemail/authenticate_nominal/configs/ast2/pjsip.conf
D tests/apps/voicemail/authenticate_nominal/configs/ast2/sip.conf
M tests/apps/voicemail/authenticate_nominal/run-test
M tests/apps/voicemail/authenticate_nominal/test-config.yaml
A tests/apps/voicemail/check_voicemail_callback/configs/ast1/pjsip.conf
D tests/apps/voicemail/check_voicemail_callback/configs/ast1/sip.conf
A tests/apps/voicemail/check_voicemail_callback/configs/ast2/pjsip.conf
D tests/apps/voicemail/check_voicemail_callback/configs/ast2/sip.conf
M tests/apps/voicemail/check_voicemail_callback/run-test
M tests/apps/voicemail/check_voicemail_callback/test-config.yaml
A tests/apps/voicemail/check_voicemail_delete/configs/ast1/pjsip.conf
D tests/apps/voicemail/check_voicemail_delete/configs/ast1/sip.conf
A tests/apps/voicemail/check_voicemail_delete/configs/ast2/pjsip.conf
D tests/apps/voicemail/check_voicemail_delete/configs/ast2/sip.conf
M tests/apps/voicemail/check_voicemail_delete/run-test
M tests/apps/voicemail/check_voicemail_delete/test-config.yaml
A tests/apps/voicemail/check_voicemail_dialout/configs/ast1/pjsip.conf
D tests/apps/voicemail/check_voicemail_dialout/configs/ast1/sip.conf
A tests/apps/voicemail/check_voicemail_dialout/configs/ast2/pjsip.conf
D tests/apps/voicemail/check_voicemail_dialout/configs/ast2/sip.conf
M tests/apps/voicemail/check_voicemail_dialout/run-test
M tests/apps/voicemail/check_voicemail_dialout/test-config.yaml
A tests/apps/voicemail/check_voicemail_envelope/configs/ast1/pjsip.conf
D tests/apps/voicemail/check_voicemail_envelope/configs/ast1/sip.conf
A tests/apps/voicemail/check_voicemail_envelope/configs/ast2/pjsip.conf
D tests/apps/voicemail/check_voicemail_envelope/configs/ast2/sip.conf
M tests/apps/voicemail/check_voicemail_envelope/run-test
M tests/apps/voicemail/check_voicemail_envelope/test-config.yaml
A tests/apps/voicemail/check_voicemail_forward/configs/ast1/pjsip.conf
D tests/apps/voicemail/check_voicemail_forward/configs/ast1/sip.conf
A tests/apps/voicemail/check_voicemail_forward/configs/ast2/pjsip.conf
D tests/apps/voicemail/check_voicemail_forward/configs/ast2/sip.conf
M tests/apps/voicemail/check_voicemail_forward/run-test
M tests/apps/voicemail/check_voicemail_forward/test-config.yaml
A tests/apps/voicemail/check_voicemail_forward_hangup/configs/ast1/pjsip.conf
D tests/apps/voicemail/check_voicemail_forward_hangup/configs/ast1/sip.conf
A tests/apps/voicemail/check_voicemail_forward_hangup/configs/ast2/pjsip.conf
D tests/apps/voicemail/check_voicemail_forward_hangup/configs/ast2/sip.conf
M tests/apps/voicemail/check_voicemail_forward_hangup/run-test
M tests/apps/voicemail/check_voicemail_forward_hangup/test-config.yaml
A tests/apps/voicemail/check_voicemail_forward_with_prepend/configs/ast1/pjsip.conf
D tests/apps/voicemail/check_voicemail_forward_with_prepend/configs/ast1/sip.conf
A tests/apps/voicemail/check_voicemail_forward_with_prepend/configs/ast2/pjsip.conf
D tests/apps/voicemail/check_voicemail_forward_with_prepend/configs/ast2/sip.conf
M tests/apps/voicemail/check_voicemail_forward_with_prepend/run-test
M tests/apps/voicemail/check_voicemail_forward_with_prepend/test-config.yaml
A tests/apps/voicemail/check_voicemail_new_user/configs/ast1/pjsip.conf
D tests/apps/voicemail/check_voicemail_new_user/configs/ast1/sip.conf
A tests/apps/voicemail/check_voicemail_new_user/configs/ast2/pjsip.conf
D tests/apps/voicemail/check_voicemail_new_user/configs/ast2/sip.conf
M tests/apps/voicemail/check_voicemail_new_user/run-test
M tests/apps/voicemail/check_voicemail_new_user/test-config.yaml
A tests/apps/voicemail/check_voicemail_new_user_hangup/configs/ast1/pjsip.conf
D tests/apps/voicemail/check_voicemail_new_user_hangup/configs/ast1/sip.conf
A tests/apps/voicemail/check_voicemail_new_user_hangup/configs/ast2/pjsip.conf
D tests/apps/voicemail/check_voicemail_new_user_hangup/configs/ast2/sip.conf
M tests/apps/voicemail/check_voicemail_new_user_hangup/run-test
M tests/apps/voicemail/check_voicemail_new_user_hangup/test-config.yaml
A tests/apps/voicemail/check_voicemail_nominal/configs/ast1/pjsip.conf
D tests/apps/voicemail/check_voicemail_nominal/configs/ast1/sip.conf
A tests/apps/voicemail/check_voicemail_nominal/configs/ast2/pjsip.conf
D tests/apps/voicemail/check_voicemail_nominal/configs/ast2/sip.conf
M tests/apps/voicemail/check_voicemail_nominal/run-test
M tests/apps/voicemail/check_voicemail_nominal/test-config.yaml
A tests/apps/voicemail/check_voicemail_options_change_password/configs/ast1/pjsip.conf
D tests/apps/voicemail/check_voicemail_options_change_password/configs/ast1/sip.conf
A tests/apps/voicemail/check_voicemail_options_change_password/configs/ast2/pjsip.conf
D tests/apps/voicemail/check_voicemail_options_change_password/configs/ast2/sip.conf
M tests/apps/voicemail/check_voicemail_options_change_password/run-test
M tests/apps/voicemail/check_voicemail_options_change_password/test-config.yaml
A tests/apps/voicemail/check_voicemail_options_change_password_spooldir/configs/ast1/pjsip.conf
D tests/apps/voicemail/check_voicemail_options_change_password_spooldir/configs/ast1/sip.conf
A tests/apps/voicemail/check_voicemail_options_change_password_spooldir/configs/ast2/pjsip.conf
D tests/apps/voicemail/check_voicemail_options_change_password_spooldir/configs/ast2/sip.conf
M tests/apps/voicemail/check_voicemail_options_change_password_spooldir/run-test
M tests/apps/voicemail/check_voicemail_options_change_password_spooldir/test-config.yaml
A tests/apps/voicemail/check_voicemail_options_record_busy/configs/ast1/pjsip.conf
D tests/apps/voicemail/check_voicemail_options_record_busy/configs/ast1/sip.conf
A tests/apps/voicemail/check_voicemail_options_record_busy/configs/ast2/pjsip.conf
D tests/apps/voicemail/check_voicemail_options_record_busy/configs/ast2/sip.conf
M tests/apps/voicemail/check_voicemail_options_record_busy/run-test
M tests/apps/voicemail/check_voicemail_options_record_busy/test-config.yaml
A tests/apps/voicemail/check_voicemail_options_record_name/configs/ast1/pjsip.conf
D tests/apps/voicemail/check_voicemail_options_record_name/configs/ast1/sip.conf
A tests/apps/voicemail/check_voicemail_options_record_name/configs/ast2/pjsip.conf
D tests/apps/voicemail/check_voicemail_options_record_name/configs/ast2/sip.conf
M tests/apps/voicemail/check_voicemail_options_record_name/run-test
M tests/apps/voicemail/check_voicemail_options_record_name/test-config.yaml
A tests/apps/voicemail/check_voicemail_options_record_temp/configs/ast1/pjsip.conf
D tests/apps/voicemail/check_voicemail_options_record_temp/configs/ast1/sip.conf
A tests/apps/voicemail/check_voicemail_options_record_temp/configs/ast2/pjsip.conf
D tests/apps/voicemail/check_voicemail_options_record_temp/configs/ast2/sip.conf
M tests/apps/voicemail/check_voicemail_options_record_temp/run-test
M tests/apps/voicemail/check_voicemail_options_record_temp/test-config.yaml
A tests/apps/voicemail/check_voicemail_options_record_unavail/configs/ast1/pjsip.conf
D tests/apps/voicemail/check_voicemail_options_record_unavail/configs/ast1/sip.conf
A tests/apps/voicemail/check_voicemail_options_record_unavail/configs/ast2/pjsip.conf
D tests/apps/voicemail/check_voicemail_options_record_unavail/configs/ast2/sip.conf
M tests/apps/voicemail/check_voicemail_options_record_unavail/run-test
M tests/apps/voicemail/check_voicemail_options_record_unavail/test-config.yaml
A tests/apps/voicemail/check_voicemail_reply/configs/ast1/pjsip.conf
D tests/apps/voicemail/check_voicemail_reply/configs/ast1/sip.conf
A tests/apps/voicemail/check_voicemail_reply/configs/ast2/pjsip.conf
D tests/apps/voicemail/check_voicemail_reply/configs/ast2/sip.conf
M tests/apps/voicemail/check_voicemail_reply/run-test
M tests/apps/voicemail/check_voicemail_reply/test-config.yaml
A tests/apps/voicemail/check_voicemail_while_leaving_msg/configs/ast1/pjsip.conf
D tests/apps/voicemail/check_voicemail_while_leaving_msg/configs/ast1/sip.conf
A tests/apps/voicemail/check_voicemail_while_leaving_msg/configs/ast2/pjsip.conf
D tests/apps/voicemail/check_voicemail_while_leaving_msg/configs/ast2/sip.conf
M tests/apps/voicemail/check_voicemail_while_leaving_msg/run-test
M tests/apps/voicemail/check_voicemail_while_leaving_msg/test-config.yaml
A tests/apps/voicemail/leave_voicemail_contexts/configs/ast1/pjsip.conf
D tests/apps/voicemail/leave_voicemail_contexts/configs/ast1/sip.conf
A tests/apps/voicemail/leave_voicemail_contexts/configs/ast2/pjsip.conf
D tests/apps/voicemail/leave_voicemail_contexts/configs/ast2/sip.conf
M tests/apps/voicemail/leave_voicemail_contexts/run-test
M tests/apps/voicemail/leave_voicemail_contexts/test-config.yaml
A tests/apps/voicemail/leave_voicemail_external_notification/configs/ast1/pjsip.conf
D tests/apps/voicemail/leave_voicemail_external_notification/configs/ast1/sip.conf
A tests/apps/voicemail/leave_voicemail_external_notification/configs/ast2/pjsip.conf
D tests/apps/voicemail/leave_voicemail_external_notification/configs/ast2/sip.conf
M tests/apps/voicemail/leave_voicemail_external_notification/run-test
M tests/apps/voicemail/leave_voicemail_external_notification/test-config.yaml
A tests/apps/voicemail/leave_voicemail_forwarding/configs/ast1/pjsip.conf
D tests/apps/voicemail/leave_voicemail_forwarding/configs/ast1/sip.conf
A tests/apps/voicemail/leave_voicemail_forwarding/configs/ast2/pjsip.conf
D tests/apps/voicemail/leave_voicemail_forwarding/configs/ast2/sip.conf
M tests/apps/voicemail/leave_voicemail_forwarding/run-test
M tests/apps/voicemail/leave_voicemail_forwarding/test-config.yaml
A tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/configs/ast1/pjsip.conf
D tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/configs/ast1/sip.conf
A tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/configs/ast2/pjsip.conf
D tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/configs/ast2/sip.conf
M tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/run-test
M tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/test-config.yaml
A tests/apps/voicemail/leave_voicemail_nominal/configs/ast1/pjsip.conf
D tests/apps/voicemail/leave_voicemail_nominal/configs/ast1/sip.conf
A tests/apps/voicemail/leave_voicemail_nominal/configs/ast2/pjsip.conf
D tests/apps/voicemail/leave_voicemail_nominal/configs/ast2/sip.conf
M tests/apps/voicemail/leave_voicemail_nominal/run-test
A tests/apps/voicemail/leave_voicemail_priority/configs/ast1/pjsip.conf
D tests/apps/voicemail/leave_voicemail_priority/configs/ast1/sip.conf
A tests/apps/voicemail/leave_voicemail_priority/configs/ast2/pjsip.conf
D tests/apps/voicemail/leave_voicemail_priority/configs/ast2/sip.conf
M tests/apps/voicemail/leave_voicemail_priority/run-test
M tests/apps/voicemail/leave_voicemail_priority/test-config.yaml
240 files changed, 3,304 insertions(+), 1,232 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/41/9041/3
-- 
To view, visit https://gerrit.asterisk.org/9041
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: certified/13.21
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2722aa6b670e500063a497371f7a7749d59e13e5
Gerrit-Change-Number: 9041
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180529/19830d5c/attachment-0001.html>