[Asterisk-code-review] netsock2: Add ast sockaddr resolve first af to netsock2 publ... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/8987 )

Change subject: netsock2: Add ast_sockaddr_resolve_first_af to netsock2 public API
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/8987/1/include/asterisk/netsock2.h
File include/asterisk/netsock2.h:

https://gerrit.asterisk.org/#/c/8987/1/include/asterisk/netsock2.h@440
PS1, Line 440: /*! 
Redness.


https://gerrit.asterisk.org/#/c/8987/1/include/asterisk/netsock2.h@466
PS1, Line 466:  * \param family Only addresses of the given family will be returned. Use 0 or
             :  * AST_AF_UNSPEC to get addresses of all families.
What will the behavior actually be for this (since it returns only one address) if you don't specify an address family? Is it defined or undefined?



-- 
To view, visit https://gerrit.asterisk.org/8987
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id52e23be885601c51d70259f62de1a5e59d38d04
Gerrit-Change-Number: 8987
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 14 May 2018 11:16:35 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180514/abb2a73e/attachment.html>