[Asterisk-code-review] manager: fix digest auth for ami/http mechanism. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8938 )

Change subject: manager: fix digest auth for ami/http mechanism.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/8938/2/main/manager.c
File main/manager.c:

https://gerrit.asterisk.org/#/c/8938/2/main/manager.c@8014
PS2, Line 8014: 		if (ast_asprintf(&a2, "%s:%s", ast_get_http_method(method), d.uri) > 0) {
I think instead you need to check for < 0 (failure) and on failure run:
ast_http_request_close_on_completion(ser);
ast_http_error(ser, 500, "Server Error", "Internal Server Error (out of memory)");
return 0;



-- 
To view, visit https://gerrit.asterisk.org/8938
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I660609db13b8f9e5f9567f339dd804f4985d41b3
Gerrit-Change-Number: 8938
Gerrit-PatchSet: 2
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Tue, 08 May 2018 10:56:51 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180508/f0872637/attachment-0001.html>