[Asterisk-code-review] pjsip: Increase maximum number of usable ciphers & other cle... (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/8906 )

Change subject: pjsip: Increase maximum number of usable ciphers & other cleanups
......................................................................


Patch Set 3:

> > I'm not sure that this is adequate enough of a solution. We have
 > a
 > > hard-coded maximum of 64 in ast_sip_transport_state.
 > 
 > Very possible I'm misunderstanding, but I think the hard-coded
 > maximum of 64 limits the number of ciphers which can be configured
 > per transport, where PJ_SSL_SOCK_MAX_CIPHERS defines the maximum
 > number of ciphers that can exist on the system?  So with this patch
 > you're still limited to configuring up to 64 ciphers per transport,
 > but those 64 can be chosen from the full list of ciphers that exist
 > instead of just the first 100.
 > 
 > Obviously fixing the 64 would be an ABI change so I'll leave it to
 > others to comment on if it can be fixed in 13/15.

Yes, I think you're right. They are two separate issues so I think this patch is good-ish as is.


-- 
To view, visit https://gerrit.asterisk.org/8906
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea620f03915a1b873e79743154255c3148a514e7
Gerrit-Change-Number: 8906
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 02 May 2018 14:00:05 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180502/323fc523/attachment.html>