[Asterisk-code-review] install prereq: Split into multiple scripts and data. (asterisk[master])

Alexander Traud asteriskteam at digium.com
Wed May 2 06:15:34 CDT 2018


Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/8516 )

Change subject: install_prereq: Split into multiple scripts and data.
......................................................................


Patch Set 3:

Paul, thank you very much for your contribution mentioning bindep. Last weekend, I had some time to play with it, and it is simply great. Especially because bindep supports profiles. That way, the already existing six profiles default|pjproject|optional|unpackaged|all|test are handled like a breeze. Furthermore, it supports platform versions which comes handy with some package versions like Lua and GMime. Additionally, because every package gets its own line in the source code, 'git blame' works directly. Finally, transforming an existing platform into the format bindep expects, took me just seconds. I really like bindep.

Two drawbacks, no offense, just documenting:
1. Python, pip, and/or bindep must be installed.
2. From BSD based platforms, bindep supports just Darwin. FreeBSD, OpenBSD, NetBSD, and DragonFly are already in Asterisk but not in bindep, yet.

When it comes to 1: Asking the user to install pip should not be that issue:
- Python is installed on many platforms on default anyway.
- For the profile TEST_FRAMEWORK, all this is required anyway.
However, installing pip correctly as intended by the underlying platform and/or the Python community is a challenge, see <https://packaging.python.org/tutorials/installing-packages/>. The question is, whether all this should be put in the existing install_prereq script. For example in Ubuntu 18.04 LTS, an easy but not recommended way would be:
sudo apt install --no-install-recommends python3-pip
sudo -H pip3 install bindep

When it comes to 2: That could be contributed back to bindep.

I really would like to go for bindep, especially because it looks like to get a de-facto standard. Therefore, Paul, thanks again. I was looking for something like bindep for years. Thanks to you, I have found it finally.

Anyway, somebody has to do/implement all this. I am a bit blocked right now, because I have not seen the approach of George, yet.


-- 
To view, visit https://gerrit.asterisk.org/8516
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16a26b19047a8b3da3947c7953cd104241b7472d
Gerrit-Change-Number: 8516
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Paul Belanger <pabelanger at gmail.com>
Gerrit-Comment-Date: Wed, 02 May 2018 11:15:34 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180502/e9a07187/attachment.html>


More information about the asterisk-code-review mailing list