[Asterisk-code-review] BuildSystem: Go for Python 2 explicitly, because that is cur... (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8673 )

Change subject: BuildSystem: Go for Python 2 explicitly, because that is currently needed.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/8673/1/configure.ac
File configure.ac:

https://gerrit.asterisk.org/#/c/8673/1/configure.ac@264
PS1, Line 264: AC_PATH_PROGS([PYTHON], [python2 python2.7], :)
8646 and cherry-picks are close to having full support for the build system to use python3.  Eventually we'll run into systems which do not have python2 at all so I think we should just detect `python`.  The correct fix is for the build system to be compatible with whatever python the OS gives us (2.x or 3.x).


https://gerrit.asterisk.org/#/c/8673/1/configure.ac@2313
PS1, Line 2313: AST_PKG_CONFIG_CHECK([PYTHONDEV], [python < 3])
              : AST_PKG_CONFIG_CHECK([PYTHONDEV], [python2])
              : AST_PKG_CONFIG_CHECK([PYTHONDEV], [python-2.7])
Maybe I missed it in the bug report but why is this needed?  I understand the 'python < 3' but which platforms require we check for python2 or python-2.7?



-- 
To view, visit https://gerrit.asterisk.org/8673
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29e694dc7e92510dc26b15895b55f78f67146b2c
Gerrit-Change-Number: 8673
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Tue, 27 Mar 2018 13:02:47 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180327/fdbac2de/attachment.html>