[Asterisk-code-review] Add data buffer API to store packets. (asterisk[15])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/8604 )

Change subject: Add data buffer API to store packets.
......................................................................


Patch Set 8:

(2 comments)

https://gerrit.asterisk.org/#/c/8604/8/main/data_buffer.c
File main/data_buffer.c:

https://gerrit.asterisk.org/#/c/8604/8/main/data_buffer.c@169
PS8, Line 169: 	if (size < 1) {
Would this be better as an assert?


https://gerrit.asterisk.org/#/c/8604/8/main/data_buffer.c@184
PS8, Line 184: 				if (buffer->free_fn) {
Just a thought... How about having a default do-nothing free_fn function which will allow you to elide all of these NULL checks?



-- 
To view, visit https://gerrit.asterisk.org/8604
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff13c5d4795d52356959fe2a57360cd57dfade07
Gerrit-Change-Number: 8604
Gerrit-PatchSet: 8
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 23 Mar 2018 20:08:35 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180323/ff795732/attachment.html>