[Asterisk-code-review] Enable early-media video (asterisk[13])

[Florian Floimair]

Florian Floimair has posted comments on this change. ( https://gerrit.asterisk.org/8398 )

Change subject: Enable early-media video
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/8398/1//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/8398/1//COMMIT_MSG@7
PS1, Line 7: Enable early-media video
> That's
Done


https://gerrit.asterisk.org/#/c/8398/1/apps/app_dial.c
File apps/app_dial.c:

https://gerrit.asterisk.org/#/c/8398/1/apps/app_dial.c@1612
PS1, Line 1612: 			case AST_FRAME_VOICE:
              : 			case AST_FRAME_IMAGE:
> Should also add AST_FRAME_VIDEO case here so the caller could see early vid
Good point.
This should then probably be a configurable option using a parameter for the Dial application.
I'm thinking of the door call case where this can be a privacy/security issue (e.g. you ring at the door and can see right away what's happening inside).



-- 
To view, visit https://gerrit.asterisk.org/8398
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I9842e1dc2f6e1c2c49dc33fe615255007d2f821e
Gerrit-Change-Number: 8398
Gerrit-PatchSet: 1
Gerrit-Owner: Florian Floimair <f.floimair at commend.com>
Gerrit-Reviewer: Florian Floimair <f.floimair at commend.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 02 Mar 2018 09:40:40 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180302/4f369568/attachment.html>