[Asterisk-code-review] chan sip: Emit a second ringing event to ensure channel is f... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8299 )

Change subject: chan_sip: Emit a second ringing event to ensure channel is found.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/8299/1/channels/chan_sip.c
File channels/chan_sip.c:

https://gerrit.asterisk.org/#/c/8299/1/channels/chan_sip.c@23759
PS1, Line 23759: 					ast_devstate_changed(AST_DEVICE_UNKNOWN, AST_DEVSTATE_NOT_CACHABLE, "SIP/%s", p->relatedpeer->name);
Does this need to be treated like in sip_peer_hold() to determine if the event should be cacheable?



-- 
To view, visit https://gerrit.asterisk.org/8299
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I547a458fc59721c918cb48be060cbfc3c88bcf9c
Gerrit-Change-Number: 8299
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 01 Mar 2018 23:24:09 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180301/b7ef44e5/attachment.html>