[Asterisk-code-review] res rtp asterisk: Add support for sending NACK requests. (asterisk[master])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change. ( https://gerrit.asterisk.org/9225 )

Change subject: res_rtp_asterisk: Add support for sending NACK requests.
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.asterisk.org/#/c/9225/4/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/9225/4/res/res_rtp_asterisk.c@4402
PS4, Line 4402: 	if (res == 0 || res == 1) {
> So the issue here is that there are 2 different things that can happen that
Let me read back over this and get back to you so I don't say something silly here that you've already considered :-)


https://gerrit.asterisk.org/#/c/9225/4/res/res_rtp_asterisk.c@4419
PS4, Line 4419: 		ast_rtp_instance_get_remote_address(instance, &remote_address);
> This was done when ast_rtcp_write_report was one function, it sent it out i
Ah, ok.  Sorry, I noticed this after writing the comment and forgot to delete my question.  Thanks for answering it anyways :-)



-- 
To view, visit https://gerrit.asterisk.org/9225
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idab644b08a1593659c92cda64132ccc203fe991d
Gerrit-Change-Number: 9225
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Comment-Date: Fri, 29 Jun 2018 19:27:53 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180629/666307bd/attachment.html>