[Asterisk-code-review] pjsip/subscriptions/ast restart: Sporadic failures due to NO... (testsuite[master])

[Jenkins2]

Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/9308 )

Change subject: pjsip/subscriptions/ast_restart: Sporadic failures due to NOTIFY retransmission
......................................................................

pjsip/subscriptions/ast_restart: Sporadic failures due to NOTIFY retransmission

A race can sometimes occur between receiving a 200 OK for a NOTIFY and
retransmission of it, which will cause the test to fail if the NOTIFY gets
retransmitted.

This patch increases the t1 timer value in pjsip, so the test has time to
receive and process the NOTIFY's 200 OK without the retransmission timer being
fired first.

ASTERISK-27764 #close

Change-Id: I6bd5d7ddd9694140360392f70daba1b39c9c61d9
---
M tests/channels/pjsip/subscriptions/ast_restart/configs/ast1/pjsip.conf
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/tests/channels/pjsip/subscriptions/ast_restart/configs/ast1/pjsip.conf b/tests/channels/pjsip/subscriptions/ast_restart/configs/ast1/pjsip.conf
index ead6d27..4c43956 100644
--- a/tests/channels/pjsip/subscriptions/ast_restart/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/subscriptions/ast_restart/configs/ast1/pjsip.conf
@@ -6,6 +6,12 @@
 ; the subscription recreation to be seen after the restart.
 debug=yes
 
+[system]
+type=system
+; Sometimes we are still processing the 200 OK for a NOTIFY, and another
+; NOTIFY gets retransmitted. So raise the t1 timer a bit.
+timer_t1=2000
+
 [local]
 type=transport
 protocol=udp

-- 
To view, visit https://gerrit.asterisk.org/9308
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6bd5d7ddd9694140360392f70daba1b39c9c61d9
Gerrit-Change-Number: 9308
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180629/f3854b7e/attachment.html>