[Asterisk-code-review] res pjsip messaging: Allow application/* for in-dialog MESS... (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/9292 )

Change subject: res_pjsip_messaging:  Allow application/* for in-dialog MESSAGEs
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.asterisk.org/#/c/9292/2/res/res_pjsip_messaging.c
File res/res_pjsip_messaging.c:

https://gerrit.asterisk.org/#/c/9292/2/res/res_pjsip_messaging.c@91
PS2, Line 91: 	static const pj_str_t text = { "text", 4};
            : 	static const pj_str_t application = { "appli
> These should be made "static const".  There is no need to initialize them f
Done


https://gerrit.asterisk.org/#/c/9292/3/res/res_pjsip_messaging.c
File res/res_pjsip_messaging.c:

https://gerrit.asterisk.org/#/c/9292/3/res/res_pjsip_messaging.c@101
PS3, Line 101: 		|| pj_stricmp(&rdata->msg_info.msg->body->content_type.type, &application) == 0)) {
> Also you didn't answer my earlier question about actually needing
 > to check this location because the caller doesn't look at
 > rdata->msg_info.ctype->media.type.

It's there for feature parity with the other function.



-- 
To view, visit https://gerrit.asterisk.org/9292
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e54d8cc6158dc47eb8fdd6ba0108c6fd53f2818
Gerrit-Change-Number: 9292
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 27 Jun 2018 12:47:08 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180627/32ee9477/attachment.html>