[Asterisk-code-review] matcher.py: Always check final conditions (testsuite[13])
Kevin Harwell
asteriskteam at digium.com
Fri Jun 22 14:27:00 CDT 2018
Hello Jenkins2,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/9278
to look at the new patch set (#2).
Change subject: matcher.py: Always check final conditions
......................................................................
matcher.py: Always check final conditions
The matcher functionality was checking the final conditions only if the test
was marked as passed. Since the initial default value for that the test_case
variable is 'None' this could cause the test to fail, but not error messages
were output.
This patch makes it so the final condtions in matcher are always checked when
the test ends. Also if all final conditions pass then the test object is set
to passing (passed=true). Lastly the error message output was updated to make
it a little more readable.
Change-Id: Ibdd3041e8fb023b9396d80ec766ade934e50bcaa
---
M lib/python/asterisk/matcher.py
M lib/python/asterisk/self_test/test2_matcher.py
2 files changed, 17 insertions(+), 22 deletions(-)
git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/78/9278/2
--
To view, visit https://gerrit.asterisk.org/9278
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibdd3041e8fb023b9396d80ec766ade934e50bcaa
Gerrit-Change-Number: 9278
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180622/5c25c66c/attachment.html>
More information about the asterisk-code-review
mailing list