[Asterisk-code-review] Begin work on python3 compatability. (testsuite[master])

[Alexander Traud]

Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/8854 )

Change subject: Begin work on python3 compatability.
......................................................................


Patch Set 7:

> (1 comment)

Still crashes. However, as you noted it is not reproducible. Now, I get a crash in test/apps/sendtext/enhanced.

Unicode and US-ASCII do not work as encoding because 155 is not defined in those character sets. But that cannot be the cause alone, because I had an error about another codepoint before that test. I cannot help, because I do not understand that source code. On the first glance, looks like you are dealing not with strings but bytes. If you deal with bytes, you can forget any charset in Python because it is one of the languages which does codepage checks = if the codepoint is not defined it bails. US-ASCII is a sub-set of UTF-8. US-ASCII is a subset of ISO-8859-1. ISO-8859-1 is a subset of winlatin1. However, ISO-8859-1 is not a subset of UTF-8. Furthermore, Unicode defines a lot of character sequences as invalid. Therefore and because Python checks, you have to be absolutely sure what you deal with (bytes, characters and which encoding). Otherwise, you can forget it. If you deal with a Terminal as middle-man, … then it depends even on the locale of the user.

Furthermore, I cannot help to test anymore because the whole suite crashes and not simply a test fails. Finally, I see a lot of regressions already until I reach a crash. I am sorry to give no positive result because you did a tremendous work already.


-- 
To view, visit https://gerrit.asterisk.org/8854
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If76c2d3e11e4ab4552d0df7841287c8bb2de7918
Gerrit-Change-Number: 8854
Gerrit-PatchSet: 7
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 21 Jun 2018 11:07:10 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180621/b670b62a/attachment.html>