[Asterisk-code-review] app queue: Add option for predial handlers on caller and cal... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9180 )

Change subject: app_queue: Add option for predial handlers on caller and callee channels
......................................................................


Patch Set 2: Code-Review-1

(4 comments)

Nearly there

https://gerrit.asterisk.org/#/c/9180/2//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/9180/2//COMMIT_MSG@14
PS2, Line 14: Gosub is executed on originating channel when it gets first in line
            : and on each newly created outgoing channel.
This sentence is not true.  The caller routine gets executed when the caller first enters the queue.


https://gerrit.asterisk.org/#/c/9180/2/apps/app_queue.c
File apps/app_queue.c:

https://gerrit.asterisk.org/#/c/9180/2/apps/app_queue.c@4653
PS2, Line 4653: 	if(qe->predial_callee) {
Guidelines: Space after keywords.
if () {
}

You have cut-n-pasted this in several places.


https://gerrit.asterisk.org/#/c/9180/2/apps/app_queue.c@4674
PS2, Line 4674: 					if(qe->predial_callee) {
Need to check if cur->chan is not NULL as the channel may not have been created.


https://gerrit.asterisk.org/#/c/9180/2/apps/app_queue.c@4683
PS2, Line 4683: 			if(qe->predial_callee) {
Need to check if cur->chan is not NULL as the channel may not have been created.



-- 
To view, visit https://gerrit.asterisk.org/9180
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5acf5c32587ee008658d12e8a8049eb8fa4d0f24
Gerrit-Change-Number: 9180
Gerrit-PatchSet: 2
Gerrit-Owner: Kristian Høgh <kfh at uni-tel.dk>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 20 Jun 2018 14:58:10 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180620/f1343b1d/attachment.html>