[Asterisk-code-review] voicemail: Fix tests after chan sip to chan pjsip conversion. (testsuite[master])

Richard Mudgett asteriskteam at digium.com
Tue Jun 19 17:34:15 CDT 2018


Richard Mudgett has uploaded this change for review. ( https://gerrit.asterisk.org/9228


Change subject: voicemail: Fix tests after chan_sip to chan_pjsip conversion.
......................................................................

voicemail: Fix tests after chan_sip to chan_pjsip conversion.

* Fixed a syntax error in
tests/apps/voicemail/leave_voicemail_forwarding/run-test
* Fixed SIP -> PJSIP channel name reference in
tests/apps/voicemail/leave_voicemail_nominal/run-test
tests/apps/voicemail/leave_voicemail_priority/run-test
* Updated voicemail test dependencies.

Change-Id: I753a1712504169634d6761db2343e5f3429872e9
---
M tests/apps/voicemail/authenticate_extensions/test-config.yaml
M tests/apps/voicemail/authenticate_invalid_mailbox/test-config.yaml
M tests/apps/voicemail/authenticate_invalid_password/test-config.yaml
M tests/apps/voicemail/authenticate_nominal/test-config.yaml
M tests/apps/voicemail/check_voicemail_callback/test-config.yaml
M tests/apps/voicemail/check_voicemail_delete/test-config.yaml
M tests/apps/voicemail/check_voicemail_dialout/test-config.yaml
M tests/apps/voicemail/check_voicemail_envelope/test-config.yaml
M tests/apps/voicemail/check_voicemail_forward/test-config.yaml
M tests/apps/voicemail/check_voicemail_forward_hangup/test-config.yaml
M tests/apps/voicemail/check_voicemail_forward_with_prepend/test-config.yaml
M tests/apps/voicemail/check_voicemail_new_user/test-config.yaml
M tests/apps/voicemail/check_voicemail_new_user_hangup/test-config.yaml
M tests/apps/voicemail/check_voicemail_nominal/test-config.yaml
M tests/apps/voicemail/check_voicemail_options_change_password/test-config.yaml
M tests/apps/voicemail/check_voicemail_options_change_password_spooldir/test-config.yaml
M tests/apps/voicemail/check_voicemail_options_record_busy/test-config.yaml
M tests/apps/voicemail/check_voicemail_options_record_name/test-config.yaml
M tests/apps/voicemail/check_voicemail_options_record_temp/test-config.yaml
M tests/apps/voicemail/check_voicemail_options_record_unavail/test-config.yaml
M tests/apps/voicemail/check_voicemail_reply/test-config.yaml
M tests/apps/voicemail/check_voicemail_while_leaving_msg/test-config.yaml
M tests/apps/voicemail/func_vmcount/test-config.yaml
M tests/apps/voicemail/leave_voicemail_contexts/test-config.yaml
M tests/apps/voicemail/leave_voicemail_external_notification/test-config.yaml
M tests/apps/voicemail/leave_voicemail_forwarding/run-test
M tests/apps/voicemail/leave_voicemail_forwarding/test-config.yaml
M tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/test-config.yaml
M tests/apps/voicemail/leave_voicemail_nominal/run-test
M tests/apps/voicemail/leave_voicemail_nominal/test-config.yaml
M tests/apps/voicemail/leave_voicemail_priority/run-test
M tests/apps/voicemail/leave_voicemail_priority/test-config.yaml
M tests/apps/voicemail/play_message/test-config.yaml
M tests/apps/voicemail/tests.yaml
34 files changed, 186 insertions(+), 118 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/28/9228/1

diff --git a/tests/apps/voicemail/authenticate_extensions/test-config.yaml b/tests/apps/voicemail/authenticate_extensions/test-config.yaml
index 466669a..f561df7 100644
--- a/tests/apps/voicemail/authenticate_extensions/test-config.yaml
+++ b/tests/apps/voicemail/authenticate_extensions/test-config.yaml
@@ -9,9 +9,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_playback'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/authenticate_invalid_mailbox/test-config.yaml b/tests/apps/voicemail/authenticate_invalid_mailbox/test-config.yaml
index 13bf03f..1def118 100644
--- a/tests/apps/voicemail/authenticate_invalid_mailbox/test-config.yaml
+++ b/tests/apps/voicemail/authenticate_invalid_mailbox/test-config.yaml
@@ -9,9 +9,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_playback'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/authenticate_invalid_password/test-config.yaml b/tests/apps/voicemail/authenticate_invalid_password/test-config.yaml
index 0834058..e026a36 100644
--- a/tests/apps/voicemail/authenticate_invalid_password/test-config.yaml
+++ b/tests/apps/voicemail/authenticate_invalid_password/test-config.yaml
@@ -9,9 +9,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_playback'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/authenticate_nominal/test-config.yaml b/tests/apps/voicemail/authenticate_nominal/test-config.yaml
index f0f6521..cfd1f9c 100644
--- a/tests/apps/voicemail/authenticate_nominal/test-config.yaml
+++ b/tests/apps/voicemail/authenticate_nominal/test-config.yaml
@@ -10,9 +10,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_playback'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/check_voicemail_callback/test-config.yaml b/tests/apps/voicemail/check_voicemail_callback/test-config.yaml
index 7c7e112..61df89f 100644
--- a/tests/apps/voicemail/check_voicemail_callback/test-config.yaml
+++ b/tests/apps/voicemail/check_voicemail_callback/test-config.yaml
@@ -10,9 +10,11 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/check_voicemail_delete/test-config.yaml b/tests/apps/voicemail/check_voicemail_delete/test-config.yaml
index 29e02e9..65b68b1 100644
--- a/tests/apps/voicemail/check_voicemail_delete/test-config.yaml
+++ b/tests/apps/voicemail/check_voicemail_delete/test-config.yaml
@@ -10,9 +10,11 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/check_voicemail_dialout/test-config.yaml b/tests/apps/voicemail/check_voicemail_dialout/test-config.yaml
index 9d682f9..3ce70d9 100644
--- a/tests/apps/voicemail/check_voicemail_dialout/test-config.yaml
+++ b/tests/apps/voicemail/check_voicemail_dialout/test-config.yaml
@@ -9,9 +9,11 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/check_voicemail_envelope/test-config.yaml b/tests/apps/voicemail/check_voicemail_envelope/test-config.yaml
index 939ab88..2bc4679 100644
--- a/tests/apps/voicemail/check_voicemail_envelope/test-config.yaml
+++ b/tests/apps/voicemail/check_voicemail_envelope/test-config.yaml
@@ -11,9 +11,11 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/check_voicemail_forward/test-config.yaml b/tests/apps/voicemail/check_voicemail_forward/test-config.yaml
index acd7785..c3cf7d2 100644
--- a/tests/apps/voicemail/check_voicemail_forward/test-config.yaml
+++ b/tests/apps/voicemail/check_voicemail_forward/test-config.yaml
@@ -9,10 +9,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'app_playback'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_playback'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/check_voicemail_forward_hangup/test-config.yaml b/tests/apps/voicemail/check_voicemail_forward_hangup/test-config.yaml
index f0971ff..0d5c5f8 100644
--- a/tests/apps/voicemail/check_voicemail_forward_hangup/test-config.yaml
+++ b/tests/apps/voicemail/check_voicemail_forward_hangup/test-config.yaml
@@ -10,10 +10,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'app_playback'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_playback'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/check_voicemail_forward_with_prepend/test-config.yaml b/tests/apps/voicemail/check_voicemail_forward_with_prepend/test-config.yaml
index ab48613..1df05af 100644
--- a/tests/apps/voicemail/check_voicemail_forward_with_prepend/test-config.yaml
+++ b/tests/apps/voicemail/check_voicemail_forward_with_prepend/test-config.yaml
@@ -9,10 +9,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'app_playback'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_playback'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/check_voicemail_new_user/test-config.yaml b/tests/apps/voicemail/check_voicemail_new_user/test-config.yaml
index 1c4d32d..6f191c2 100644
--- a/tests/apps/voicemail/check_voicemail_new_user/test-config.yaml
+++ b/tests/apps/voicemail/check_voicemail_new_user/test-config.yaml
@@ -11,10 +11,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'app_playback'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_playback'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/check_voicemail_new_user_hangup/test-config.yaml b/tests/apps/voicemail/check_voicemail_new_user_hangup/test-config.yaml
index 2c2ed55..efb44de 100644
--- a/tests/apps/voicemail/check_voicemail_new_user_hangup/test-config.yaml
+++ b/tests/apps/voicemail/check_voicemail_new_user_hangup/test-config.yaml
@@ -10,10 +10,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'app_playback'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_playback'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/check_voicemail_nominal/test-config.yaml b/tests/apps/voicemail/check_voicemail_nominal/test-config.yaml
index 6089973..2539b32 100644
--- a/tests/apps/voicemail/check_voicemail_nominal/test-config.yaml
+++ b/tests/apps/voicemail/check_voicemail_nominal/test-config.yaml
@@ -10,9 +10,11 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/check_voicemail_options_change_password/test-config.yaml b/tests/apps/voicemail/check_voicemail_options_change_password/test-config.yaml
index b157464..7b0c7ec 100644
--- a/tests/apps/voicemail/check_voicemail_options_change_password/test-config.yaml
+++ b/tests/apps/voicemail/check_voicemail_options_change_password/test-config.yaml
@@ -11,10 +11,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'app_playback'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_playback'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/check_voicemail_options_change_password_spooldir/test-config.yaml b/tests/apps/voicemail/check_voicemail_options_change_password_spooldir/test-config.yaml
index bfd8156..fa8ba80 100644
--- a/tests/apps/voicemail/check_voicemail_options_change_password_spooldir/test-config.yaml
+++ b/tests/apps/voicemail/check_voicemail_options_change_password_spooldir/test-config.yaml
@@ -12,10 +12,12 @@
         - buildoption: 'TEST_FRAMEWORK'
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'app_playback'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_playback'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/check_voicemail_options_record_busy/test-config.yaml b/tests/apps/voicemail/check_voicemail_options_record_busy/test-config.yaml
index de47837..4bdf53b 100644
--- a/tests/apps/voicemail/check_voicemail_options_record_busy/test-config.yaml
+++ b/tests/apps/voicemail/check_voicemail_options_record_busy/test-config.yaml
@@ -8,10 +8,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'app_playback'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_playback'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/check_voicemail_options_record_name/test-config.yaml b/tests/apps/voicemail/check_voicemail_options_record_name/test-config.yaml
index 1b5dcac..6c0ecd9 100644
--- a/tests/apps/voicemail/check_voicemail_options_record_name/test-config.yaml
+++ b/tests/apps/voicemail/check_voicemail_options_record_name/test-config.yaml
@@ -8,10 +8,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'app_playback'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_playback'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/check_voicemail_options_record_temp/test-config.yaml b/tests/apps/voicemail/check_voicemail_options_record_temp/test-config.yaml
index 1b5dcac..6c0ecd9 100644
--- a/tests/apps/voicemail/check_voicemail_options_record_temp/test-config.yaml
+++ b/tests/apps/voicemail/check_voicemail_options_record_temp/test-config.yaml
@@ -8,10 +8,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'app_playback'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_playback'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/check_voicemail_options_record_unavail/test-config.yaml b/tests/apps/voicemail/check_voicemail_options_record_unavail/test-config.yaml
index b852f21..eba282b 100644
--- a/tests/apps/voicemail/check_voicemail_options_record_unavail/test-config.yaml
+++ b/tests/apps/voicemail/check_voicemail_options_record_unavail/test-config.yaml
@@ -8,10 +8,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'app_playback'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_playback'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/check_voicemail_reply/test-config.yaml b/tests/apps/voicemail/check_voicemail_reply/test-config.yaml
index 9979e6c..e6c286a 100644
--- a/tests/apps/voicemail/check_voicemail_reply/test-config.yaml
+++ b/tests/apps/voicemail/check_voicemail_reply/test-config.yaml
@@ -10,10 +10,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'app_playback'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_playback'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/check_voicemail_while_leaving_msg/test-config.yaml b/tests/apps/voicemail/check_voicemail_while_leaving_msg/test-config.yaml
index 1f86f3f..69c392c 100644
--- a/tests/apps/voicemail/check_voicemail_while_leaving_msg/test-config.yaml
+++ b/tests/apps/voicemail/check_voicemail_while_leaving_msg/test-config.yaml
@@ -14,10 +14,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk : 'app_voicemail'
-        - asterisk : 'app_senddtmf'
-        - asterisk : 'app_playback'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_playback'
+        - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/func_vmcount/test-config.yaml b/tests/apps/voicemail/func_vmcount/test-config.yaml
index 43b5874..9a185f6 100644
--- a/tests/apps/voicemail/func_vmcount/test-config.yaml
+++ b/tests/apps/voicemail/func_vmcount/test-config.yaml
@@ -7,9 +7,11 @@
 
 properties:
     dependencies:
-        - asterisk : 'app_voicemail'
         - python : 'twisted'
         - python : 'starpy'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'func_vmcount'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/leave_voicemail_contexts/test-config.yaml b/tests/apps/voicemail/leave_voicemail_contexts/test-config.yaml
index 63fe6d8..16899b3 100644
--- a/tests/apps/voicemail/leave_voicemail_contexts/test-config.yaml
+++ b/tests/apps/voicemail/leave_voicemail_contexts/test-config.yaml
@@ -8,9 +8,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk: 'app_voicemail'
+        - asterisk: 'app_playback'
         - asterisk: 'app_senddtmf'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/leave_voicemail_external_notification/test-config.yaml b/tests/apps/voicemail/leave_voicemail_external_notification/test-config.yaml
index 4f15d61..c620179 100644
--- a/tests/apps/voicemail/leave_voicemail_external_notification/test-config.yaml
+++ b/tests/apps/voicemail/leave_voicemail_external_notification/test-config.yaml
@@ -11,9 +11,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk: 'app_voicemail'
+        - asterisk: 'app_playback'
         - asterisk: 'app_senddtmf'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/leave_voicemail_forwarding/run-test b/tests/apps/voicemail/leave_voicemail_forwarding/run-test
index d604fe2..8a8ad93 100755
--- a/tests/apps/voicemail/leave_voicemail_forwarding/run-test
+++ b/tests/apps/voicemail/leave_voicemail_forwarding/run-test
@@ -107,7 +107,6 @@
 
         self.create_asterisk(2)
 
-
     def ami_connect(self, ami):
         super(LeaveVoicemailForwarding, self).ami_connect(ami)
         self.audioFile = os.path.join(os.getcwd(), "%s/sounds/talking" % (self.testParentDir))
@@ -129,7 +128,7 @@
 
     def originate_call(self):
         extension = self.extensions[self.test_counter]
-        logger.info("Originating call to PJSIP/" + str(extension)) + "@ast1"
+        logger.info("Originating call to PJSIP/" + str(extension) + "@ast1")
         df = self.ami_sender.originate("PJSIP/" + str(extension) + "@ast1", "voicemailCaller", "wait", 1, None, "CallId-" + str(extension), None, None, None, {}, True )
         df.addErrback(self.handle_originate_failure)
 
@@ -155,7 +154,6 @@
             self.sender_channel = "PJSIP/ast1-0000000" + str(self.test_counter)
             self.test_state_controller.change_state(StartVoiceMailState(self.test_state_controller, self))
             self.originate_call()
-
 
     def run(self):
         super(LeaveVoicemailForwarding, self).run()
@@ -204,4 +202,4 @@
     return 0
 
 if __name__ == "__main__":
-   sys.exit(main() or 0)
+    sys.exit(main() or 0)
diff --git a/tests/apps/voicemail/leave_voicemail_forwarding/test-config.yaml b/tests/apps/voicemail/leave_voicemail_forwarding/test-config.yaml
index 0afafa7..8eb7188 100644
--- a/tests/apps/voicemail/leave_voicemail_forwarding/test-config.yaml
+++ b/tests/apps/voicemail/leave_voicemail_forwarding/test-config.yaml
@@ -10,9 +10,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk: 'app_voicemail'
+        - asterisk: 'app_playback'
         - asterisk: 'app_senddtmf'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/test-config.yaml b/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/test-config.yaml
index 41f0078..32e9a61 100644
--- a/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/test-config.yaml
+++ b/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/test-config.yaml
@@ -10,9 +10,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk: 'app_voicemail'
+        - asterisk: 'app_playback'
         - asterisk: 'app_senddtmf'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/leave_voicemail_nominal/run-test b/tests/apps/voicemail/leave_voicemail_nominal/run-test
index 651c9d2..04d67b7 100755
--- a/tests/apps/voicemail/leave_voicemail_nominal/run-test
+++ b/tests/apps/voicemail/leave_voicemail_nominal/run-test
@@ -150,7 +150,7 @@
         else:
             """ Originate the next call and reset the state machine """
             self.test_counter += 1
-            self.sender_channel = "SIP/ast1-0000000" + str(self.test_counter)
+            self.sender_channel = "PJSIP/ast1-0000000" + str(self.test_counter)
             self.test_state_controller.change_state(StartVoiceMailState(self.test_state_controller, self))
             self.originate_call()
 
diff --git a/tests/apps/voicemail/leave_voicemail_nominal/test-config.yaml b/tests/apps/voicemail/leave_voicemail_nominal/test-config.yaml
index cc19050..772531d 100644
--- a/tests/apps/voicemail/leave_voicemail_nominal/test-config.yaml
+++ b/tests/apps/voicemail/leave_voicemail_nominal/test-config.yaml
@@ -11,8 +11,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk: 'app_voicemail'
+        - asterisk: 'app_playback'
         - asterisk: 'app_senddtmf'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/leave_voicemail_priority/run-test b/tests/apps/voicemail/leave_voicemail_priority/run-test
index 17451e7..ffc5d59 100755
--- a/tests/apps/voicemail/leave_voicemail_priority/run-test
+++ b/tests/apps/voicemail/leave_voicemail_priority/run-test
@@ -146,7 +146,7 @@
         else:
             """ Originate the next call and reset the state machine """
             self.test_counter += 1
-            self.sender_channel = "SIP/ast1-0000000" + str(self.test_counter)
+            self.sender_channel = "PJSIP/ast1-0000000" + str(self.test_counter)
             self.test_state_controller.change_state(StartVoiceMailState(self.test_state_controller, self))
             self.originate_call()
 
diff --git a/tests/apps/voicemail/leave_voicemail_priority/test-config.yaml b/tests/apps/voicemail/leave_voicemail_priority/test-config.yaml
index c89d2a1..95bb33e 100644
--- a/tests/apps/voicemail/leave_voicemail_priority/test-config.yaml
+++ b/tests/apps/voicemail/leave_voicemail_priority/test-config.yaml
@@ -9,9 +9,12 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-        - asterisk: 'app_voicemail'
+        - asterisk: 'app_playback'
         - asterisk: 'app_senddtmf'
-        - asterisk : 'chan_pjsip'
+        - asterisk: 'app_userevent'
+        - asterisk: 'app_voicemail'
+        - asterisk: 'chan_pjsip'
+        - asterisk: 'res_pjsip'
     tags:
         - voicemail
         - apps
diff --git a/tests/apps/voicemail/play_message/test-config.yaml b/tests/apps/voicemail/play_message/test-config.yaml
index 3af7af1..904ffda 100644
--- a/tests/apps/voicemail/play_message/test-config.yaml
+++ b/tests/apps/voicemail/play_message/test-config.yaml
@@ -13,6 +13,7 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
+        - asterisk: 'app_userevent'
         - asterisk: 'app_voicemail'
     tags:
         - voicemail
diff --git a/tests/apps/voicemail/tests.yaml b/tests/apps/voicemail/tests.yaml
index 0435f18..0ec6c61 100644
--- a/tests/apps/voicemail/tests.yaml
+++ b/tests/apps/voicemail/tests.yaml
@@ -1,32 +1,32 @@
 # Enter tests here in the order they should be considered for execution:
 tests:
-    - test: 'leave_voicemail_nominal'
-    - test: 'leave_voicemail_contexts'
-    - test: 'leave_voicemail_priority'
-    - test: 'leave_voicemail_forwarding'
-    - test: 'leave_voicemail_forwarding_auto_urgent'
-    - test: 'leave_voicemail_external_notification'
-    - test: 'func_vmcount'
-    - test: 'authenticate_nominal'
+    - test: 'authenticate_extensions'
     - test: 'authenticate_invalid_mailbox'
     - test: 'authenticate_invalid_password'
-    - test: 'authenticate_extensions'
-    - test: 'check_voicemail_nominal'
-    - test: 'check_voicemail_envelope'
+    - test: 'authenticate_nominal'
+    - test: 'check_voicemail_callback'
     - test: 'check_voicemail_delete'
-    - test: 'check_voicemail_new_user'
-    - test: 'check_voicemail_new_user_hangup'
-    - test: 'check_voicemail_options_record_busy'
-    - test: 'check_voicemail_options_record_unavail'
-    - test: 'check_voicemail_options_record_name'
-    - test: 'check_voicemail_options_record_temp'
-    - test: 'check_voicemail_options_change_password'
-    - test: 'check_voicemail_options_change_password_spooldir'
+    - test: 'check_voicemail_dialout'
+    - test: 'check_voicemail_envelope'
     - test: 'check_voicemail_forward'
     - test: 'check_voicemail_forward_hangup'
     - test: 'check_voicemail_forward_with_prepend'
-    - test: 'check_voicemail_callback'
-    - test: 'check_voicemail_dialout'
+    - test: 'check_voicemail_new_user'
+    - test: 'check_voicemail_new_user_hangup'
+    - test: 'check_voicemail_nominal'
+    - test: 'check_voicemail_options_change_password'
+    - test: 'check_voicemail_options_change_password_spooldir'
+    - test: 'check_voicemail_options_record_busy'
+    - test: 'check_voicemail_options_record_name'
+    - test: 'check_voicemail_options_record_temp'
+    - test: 'check_voicemail_options_record_unavail'
     - test: 'check_voicemail_reply'
     - test: 'check_voicemail_while_leaving_msg'
+    - test: 'func_vmcount'
+    - test: 'leave_voicemail_contexts'
+    - test: 'leave_voicemail_external_notification'
+    - test: 'leave_voicemail_forwarding'
+    - test: 'leave_voicemail_forwarding_auto_urgent'
+    - test: 'leave_voicemail_nominal'
+    - test: 'leave_voicemail_priority'
     - test: 'play_message'

-- 
To view, visit https://gerrit.asterisk.org/9228
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I753a1712504169634d6761db2343e5f3429872e9
Gerrit-Change-Number: 9228
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180619/6487bdf1/attachment-0001.html>


More information about the asterisk-code-review mailing list