[Asterisk-code-review] app confbridge: Enable sending events to participants (asterisk[15])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/9085 )

Change subject: app_confbridge:  Enable sending events to participants
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

Also did I miss them or can tests be written for this?

https://gerrit.asterisk.org/#/c/9085/4/apps/app_confbridge.c
File apps/app_confbridge.c:

https://gerrit.asterisk.org/#/c/9085/4/apps/app_confbridge.c@686
PS4, Line 686: return ast_json_pack("{s: [ s*, s* ] }", "media_source_track_labels",
             : 		a_label, v_label);
If a_label or v_lable is NULL I think this will crash? Did you mean to use the '?' specifier instead? Although that ('?') may be dependent on the jansson version.


https://gerrit.asterisk.org/#/c/9085/4/apps/app_confbridge.c@686
PS4, Line 686: 	return ast_json_pack("{s: [ s*, s* ] }", "media_source_track_labels",
             : 		a_label, v_label);
According to the jansson docs the '*' should "... appear inside an array or object as the last format specifier before the closing bracket or brace."



-- 
To view, visit https://gerrit.asterisk.org/9085
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I26420aa9f101f0b2387dc9e2fd10733197f1318e
Gerrit-Change-Number: 9085
Gerrit-PatchSet: 4
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 12 Jun 2018 18:14:49 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180612/70237b24/attachment.html>