[Asterisk-code-review] AST-2018-008: Fix enumeration of endpoints from ACL rejected... (testsuite[13.21])

[Jenkins2]

Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/9166 )

Change subject: AST-2018-008: Fix enumeration of endpoints from ACL rejected addresses.
......................................................................

AST-2018-008: Fix enumeration of endpoints from ACL rejected addresses.

Updated the tests/channels/pjsip/acl_call test to check for the new
response message that does not give away valid endpoints.

* Changed expected ACL rejection response code from 403 forbidden to 401
unauthorized.

* pjsip.conf: Enabled SIP message debug in the logs.

* test-config.yaml: Added missing test dependencies.

ASTERISK-27818

Change-Id: Id3c46ac3329e1447b396cf44770202b003aa3a9a
---
M tests/channels/pjsip/acl_call/configs/ast1/pjsip.conf
M tests/channels/pjsip/acl_call/sipp/testsip1-failure.xml
M tests/channels/pjsip/acl_call/sipp/testsip2-failure.xml
M tests/channels/pjsip/acl_call/sipp/testsip3-failure.xml
M tests/channels/pjsip/acl_call/sipp/testsip4-failure.xml
M tests/channels/pjsip/acl_call/sipp/testsip5-failure.xml
M tests/channels/pjsip/acl_call/test-config.yaml
7 files changed, 10 insertions(+), 5 deletions(-)

Approvals:
  Kevin Harwell: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/tests/channels/pjsip/acl_call/configs/ast1/pjsip.conf b/tests/channels/pjsip/acl_call/configs/ast1/pjsip.conf
index a6e24bc..94fd3ae 100644
--- a/tests/channels/pjsip/acl_call/configs/ast1/pjsip.conf
+++ b/tests/channels/pjsip/acl_call/configs/ast1/pjsip.conf
@@ -1,3 +1,7 @@
+[global]
+type=global
+debug=yes
+
 [local]
 type=transport
 protocol=udp
diff --git a/tests/channels/pjsip/acl_call/sipp/testsip1-failure.xml b/tests/channels/pjsip/acl_call/sipp/testsip1-failure.xml
index 4bb8104..1391782 100644
--- a/tests/channels/pjsip/acl_call/sipp/testsip1-failure.xml
+++ b/tests/channels/pjsip/acl_call/sipp/testsip1-failure.xml
@@ -52,7 +52,7 @@
         optional="true">
   </recv>
 
-  <recv response="403">
+  <recv response="401">
   </recv>
 
   <send>
diff --git a/tests/channels/pjsip/acl_call/sipp/testsip2-failure.xml b/tests/channels/pjsip/acl_call/sipp/testsip2-failure.xml
index f10dfd2..6a03cdd 100644
--- a/tests/channels/pjsip/acl_call/sipp/testsip2-failure.xml
+++ b/tests/channels/pjsip/acl_call/sipp/testsip2-failure.xml
@@ -52,7 +52,7 @@
         optional="true">
   </recv>
 
-  <recv response="403">
+  <recv response="401">
   </recv>
 
   <send>
diff --git a/tests/channels/pjsip/acl_call/sipp/testsip3-failure.xml b/tests/channels/pjsip/acl_call/sipp/testsip3-failure.xml
index f3541dc..f96e19b 100644
--- a/tests/channels/pjsip/acl_call/sipp/testsip3-failure.xml
+++ b/tests/channels/pjsip/acl_call/sipp/testsip3-failure.xml
@@ -52,7 +52,7 @@
         optional="true">
   </recv>
 
-  <recv response="403">
+  <recv response="401">
   </recv>
 
   <send>
diff --git a/tests/channels/pjsip/acl_call/sipp/testsip4-failure.xml b/tests/channels/pjsip/acl_call/sipp/testsip4-failure.xml
index 3efa4f7..0fecc2f 100644
--- a/tests/channels/pjsip/acl_call/sipp/testsip4-failure.xml
+++ b/tests/channels/pjsip/acl_call/sipp/testsip4-failure.xml
@@ -52,7 +52,7 @@
         optional="true">
   </recv>
 
-  <recv response="403">
+  <recv response="401">
   </recv>
 
   <send>
diff --git a/tests/channels/pjsip/acl_call/sipp/testsip5-failure.xml b/tests/channels/pjsip/acl_call/sipp/testsip5-failure.xml
index 8340fc0..39c14be 100644
--- a/tests/channels/pjsip/acl_call/sipp/testsip5-failure.xml
+++ b/tests/channels/pjsip/acl_call/sipp/testsip5-failure.xml
@@ -52,7 +52,7 @@
         optional="true">
   </recv>
 
-  <recv response="403">
+  <recv response="401">
   </recv>
 
   <send>
diff --git a/tests/channels/pjsip/acl_call/test-config.yaml b/tests/channels/pjsip/acl_call/test-config.yaml
index 0573828..dd51ce7 100644
--- a/tests/channels/pjsip/acl_call/test-config.yaml
+++ b/tests/channels/pjsip/acl_call/test-config.yaml
@@ -11,6 +11,7 @@
         - python : 'twisted'
         - python : 'starpy'
         - app : 'sipp'
+        - asterisk : 'res_config_sqlite3'
         - asterisk : 'res_pjsip'
     tags:
         - pjsip

-- 
To view, visit https://gerrit.asterisk.org/9166
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13.21
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3c46ac3329e1447b396cf44770202b003aa3a9a
Gerrit-Change-Number: 9166
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180611/30415f5a/attachment.html>