[Asterisk-code-review] app confbridge: Bridge and announcers not removed if confere... (asterisk[13])

[Robert Mordec]

Robert Mordec has posted comments on this change. ( https://gerrit.asterisk.org/9026 )

Change subject: app_confbridge: Bridge and announcers not removed if conference ends quickly
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/9026/1/apps/app_confbridge.c
File apps/app_confbridge.c:

https://gerrit.asterisk.org/#/c/9026/1/apps/app_confbridge.c@1449
PS1, Line 1449: 
> I don't think this channel should be pushed into the bridge at all below if
I thought the conference could be still alive at this point and its ref counter could drop later, for example during ast_autoservice_start().

It was a safer bet to add the reference check just before cleanup.

But I agree, if the conference is already dead, then everything below is a waste of time. I will add a condition for it and do some testing.


https://gerrit.asterisk.org/#/c/9026/1/apps/app_confbridge.c@1459
PS1, Line 1459: 	if (ao2_ref(conference, 0) == 1) {
> And is there a race condition at all where the conference reference count m
I admit, in my particular case (bug found in production) I didn't focus on finding out if the conference reference count was already decreased at the beginning of this function. I assumed it could decrease at any time during this execution regardless of my case. Correct me if I'm wrong. Is there something I don't see that would prevent it from happening?



-- 
To view, visit https://gerrit.asterisk.org/9026
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I947a50fb121422d90fd1816d643a54d75185a477
Gerrit-Change-Number: 9026
Gerrit-PatchSet: 1
Gerrit-Owner: Robert Mordec <r.mordec at slican.pl>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Robert Mordec <r.mordec at slican.pl>
Gerrit-Comment-Date: Wed, 06 Jun 2018 08:53:31 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180606/5b485951/attachment.html>