[Asterisk-code-review] module: Remove deprecated modules and update support levels. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9504 )

Change subject: module: Remove deprecated modules and update support levels.
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/9504/1/apps/app_adsiprog.c
File apps/app_adsiprog.c:

https://gerrit.asterisk.org/#/c/9504/1/apps/app_adsiprog.c@1613
PS1, Line 1613: 	.support_level = AST_MODULE_SUPPORT_EXTENDED,
AST_MODULE_SUPPORT_DEPRECATED

This should be done for other modules that have been marked as deprecated.


https://gerrit.asterisk.org/#/c/9504/1/apps/app_ices.c
File apps/app_ices.c:

https://gerrit.asterisk.org/#/c/9504/1/apps/app_ices.c@214
PS1, Line 214: AST_MODULE_INFO_STANDARD_EXTENDED(ASTERISK_GPL_KEY, "Encode and Stream via icecast and ices");
AST_MODULE_INFO_STANDARD_DEPRECATED

This should be done for other modules that have been marked as deprecated.


https://gerrit.asterisk.org/#/c/9504/1/channels/chan_misdn.c
File channels/chan_misdn.c:

https://gerrit.asterisk.org/#/c/9504/1/channels/chan_misdn.c@79
PS1, Line 79: 	<support_level>deprecated</support_level>
Should add that chan_dahdi with libpri replaces this channel driver.

I'd really like to see this module deleted too since it cannot be built on current OS's but Sean Bright seems to want it hanging around. :)


https://gerrit.asterisk.org/#/c/9504/1/channels/chan_vpb.cc
File channels/chan_vpb.cc:

https://gerrit.asterisk.org/#/c/9504/1/channels/chan_vpb.cc@53
PS1, Line 53: 	<support_level>deprecated</support_level>
I'd really like to see this one just deleted.



-- 
To view, visit https://gerrit.asterisk.org/9504
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64783d017b86dba9ee3c7bcfb97e59889a3f76d7
Gerrit-Change-Number: 9504
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 18 Jul 2018 16:49:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180718/200f18b5/attachment.html>