[Asterisk-code-review] res pjsip pubsub: Hold module reference for publications. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9318 )

Change subject: res_pjsip_pubsub: Hold module reference for publications.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/9318/1/res/res_pjsip_pubsub.c
File res/res_pjsip_pubsub.c:

https://gerrit.asterisk.org/#/c/9318/1/res/res_pjsip_pubsub.c@3197
PS1, Line 3197: 	ast_module_ref(ast_module_info->self);
This needs to be moved between the publication object alloc and the datastore container alloc because the destructor unrefs the module so we need to bump it before attempting to alloc the datastore container in case that fails.



-- 
To view, visit https://gerrit.asterisk.org/9318
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia98c95a15e11af25728d5fb3e56e12cda0cfc7c0
Gerrit-Change-Number: 9318
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 02 Jul 2018 14:37:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180702/4390a2e3/attachment.html>