[Asterisk-code-review] res pjsip registrar.c: Fix compiler error. (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Wed Jan 31 11:14:32 CST 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8111 )

Change subject: res_pjsip_registrar.c: Fix compiler error.
......................................................................


Patch Set 1:

> We should directly include headers which define symbols that we
 > use, but we include asterisk.h which includes asterisk/compat.h and
 > that includes signal.h (all unconditionally).  So it's odd that
 > this caused an actual failure.

asterisk/compat.h only includes signal.h if SOLARIS is defined.  On my main dev box it builds fine.  On my test box it fails.


-- 
To view, visit https://gerrit.asterisk.org/8111
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ae3aa4bf8e7386ac29ade78c0f2caed8e674fa
Gerrit-Change-Number: 8111
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 31 Jan 2018 17:14:32 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180131/366c56b7/attachment-0001.html>


More information about the asterisk-code-review mailing list