[Asterisk-code-review] headers: Consistent use of typeof and/or typeof . (asterisk[13])

Jenkins2 asteriskteam at digium.com
Mon Jan 29 10:13:38 CST 2018


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/8065 )

Change subject: headers: Consistent use of typeof and/or __typeof__.
......................................................................

headers: Consistent use of typeof and/or __typeof__.

Because of a copy-and-paste error, the Asterisk project was using __typeof
instead of typeof. It works because typeof, __typeof, and __typeof__ are
supported by GCC, but here the escaped variant was not intended. Therefore,
for consistence, we change this to typeof.

Change-Id: I2a962c3e596e882f691a19345445b14571a5f07c
---
M include/asterisk/linkedlists.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Corey Farrell: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/include/asterisk/linkedlists.h b/include/asterisk/linkedlists.h
index 8715cf1..5f50c75 100644
--- a/include/asterisk/linkedlists.h
+++ b/include/asterisk/linkedlists.h
@@ -854,7 +854,7 @@
  */
 #define AST_LIST_REMOVE(head, elm, field)						\
 	({															\
-		__typeof(elm) __elm = (elm);							\
+		typeof(elm) __elm = (elm);								\
 		if (__elm) {											\
 			if ((head)->first == __elm) {						\
 				(head)->first = __elm->field.next;				\

-- 
To view, visit https://gerrit.asterisk.org/8065
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a962c3e596e882f691a19345445b14571a5f07c
Gerrit-Change-Number: 8065
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180129/ce726533/attachment-0001.html>


More information about the asterisk-code-review mailing list