[Asterisk-code-review] BuildSystem: Remove unused variables. (asterisk[master])

Jenkins2 asteriskteam at digium.com
Mon Jan 29 09:39:56 CST 2018


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/8079 )

Change subject: BuildSystem: Remove unused variables.
......................................................................

BuildSystem: Remove unused variables.

Because of a copy-and-paste from the script build_tools/download_externals,
the script build_tools/list_valid_installed_externals got its local variables.
However in the latter, three variables were not used actually.

Change-Id: I252de5a98c17ea54459174875357c22c2eebe8d5
---
M build_tools/list_valid_installed_externals
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Corey Farrell: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/build_tools/list_valid_installed_externals b/build_tools/list_valid_installed_externals
index c371022..862447a 100755
--- a/build_tools/list_valid_installed_externals
+++ b/build_tools/list_valid_installed_externals
@@ -19,10 +19,7 @@
 
 XMLSTARLET=`getvar XMLSTARLET`
 ASTMODDIR=`getvar ASTMODDIR`
-cache_dir=`getvar EXTERNALS_CACHE_DIR`
-DOWNLOAD_TO_STDOUT=`getvar DOWNLOAD_TO_STDOUT`
 HOST_CPU=`getvar HOST_CPU`
-INSTALL=`getvar INSTALL`
 
 tmpdir=$(mktemp -d)
 if [[ -z "${tmpdir}" ]] ; then

-- 
To view, visit https://gerrit.asterisk.org/8079
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I252de5a98c17ea54459174875357c22c2eebe8d5
Gerrit-Change-Number: 8079
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180129/3155fb6b/attachment.html>


More information about the asterisk-code-review mailing list