[Asterisk-code-review] install prereq: For PJProject, point users to configure script. (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7835 )

Change subject: install_prereq: For PJProject, point users to configure script.
......................................................................


Patch Set 5:

(1 comment)

Not sure this matters but seemed worth mentioning.

https://gerrit.asterisk.org/#/c/7835/5/contrib/scripts/install_prereq
File contrib/scripts/install_prereq:

https://gerrit.asterisk.org/#/c/7835/5/contrib/scripts/install_prereq@149
PS5, Line 149: 	make all install
Has this been tested with `MAKEFLAGS=-j` in the environment?  Not sure this matters but not all Makefile's deal with this correctly, if the targets are not exactly correct the build could error out (parts of 'make install' could run before 'make all'.  This change in theory allows 'make all' and 'make install' to run at the same time.



-- 
To view, visit https://gerrit.asterisk.org/7835
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbf4b562f81f7c05bd24a3805bd46c0beb4ebd44
Gerrit-Change-Number: 7835
Gerrit-PatchSet: 5
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 23 Jan 2018 18:14:56 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180123/33004fd1/attachment.html>