[Asterisk-code-review] install prereq: Download latest Jansson. (asterisk[13])

Joshua Colp asteriskteam at digium.com
Mon Jan 22 07:31:38 CST 2018


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/8033 )

Change subject: install_prereq: Download latest Jansson.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/8033/1/contrib/scripts/install_prereq
File contrib/scripts/install_prereq:

https://gerrit.asterisk.org/#/c/8033/1/contrib/scripts/install_prereq@162
PS1, Line 162: 		wget -O - http://www.digip.org/jansson/releases/jansson-2-latest.tar.gz | zcat | tar -xf -
I'm not personally a fan of switching this to using latest instead. You don't know what will be installed and this can cause an impact to the person installing. If a change is done upstream and released that causes a problem with the way we use it, then this can break things.



-- 
To view, visit https://gerrit.asterisk.org/8033
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I65c587534c0ae364f063d68da1bed40bb3d5e8aa
Gerrit-Change-Number: 8033
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 22 Jan 2018 13:31:38 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180122/f58f6d3b/attachment.html>


More information about the asterisk-code-review mailing list