[Asterisk-code-review] channels/SIP/ami/sip notify/call id: 3PCC patch for AMI "SIP... (testsuite[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/7705 )

Change subject: channels/SIP/ami/sip_notify/call_id: 3PCC patch for AMI "SIPnotify".
......................................................................


Patch Set 6: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/7705/6/tests/channels/SIP/ami/sip_notify/call_id/configs/ast1/manager.conf
File tests/channels/SIP/ami/sip_notify/call_id/configs/ast1/manager.conf:

https://gerrit.asterisk.org/#/c/7705/6/tests/channels/SIP/ami/sip_notify/call_id/configs/ast1/manager.conf@1
PS6, Line 1: [general]
           : enabled = yes
           : port = 5038
           : 
           : [user]
           : secret = mysecret
           : permit = 127.0.0.1/255.255.255.255
           : read = all
           : write = all
The conf file is not needed as well and can be deleted.


https://gerrit.asterisk.org/#/c/7705/6/tests/channels/SIP/ami/sip_notify/call_id/test-config.yaml
File tests/channels/SIP/ami/sip_notify/call_id/test-config.yaml:

https://gerrit.asterisk.org/#/c/7705/6/tests/channels/SIP/ami/sip_notify/call_id/test-config.yaml@21
PS6, Line 21:                 - { 'key-args': {'scenario': 'caller.xml', '-i': '127.0.0.1', '-p': '5062', '-s': '3200000000', '-trace_msg': '-pause_msg_ign' } }
            :                 - { 'key-args': { 'scenario': 'callee.xml', '-i': '127.0.0.1', '-p': '5063', '-s': '3200000000', '-trace_msg': '-pause_msg_ign' } }
It doesn't appear you are using the "-s" (service) parameters in your scenarios, so this option can be safely removed.


https://gerrit.asterisk.org/#/c/7705/6/tests/channels/SIP/ami/sip_notify/call_id/test-config.yaml@41
PS6, Line 41:     minversion: [ '13.20.0', '15.3.0', '16.0.0' ]
While it shouldn't hurt things to be there 16.0.0 has not been released yet, so that version can be safely removed from the list.



-- 
To view, visit https://gerrit.asterisk.org/7705
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idccbf32ed6670a5205ee99bd7413c7fe0804efb1
Gerrit-Change-Number: 7705
Gerrit-PatchSet: 6
Gerrit-Owner: Yasuhiko Kamata <yasuhiko.kamata at nxtg.co.jp>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Yasuhiko Kamata <yasuhiko.kamata at nxtg.co.jp>
Gerrit-Comment-Date: Fri, 19 Jan 2018 21:06:08 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180119/4fdb8be1/attachment.html>