[Asterisk-code-review] install prereq: For PJProject, point users to configure script. (asterisk[13])

Alexander Traud asteriskteam at digium.com
Fri Jan 19 02:08:11 CST 2018


Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/7835 )

Change subject: install_prereq: For PJProject, point users to configure script.
......................................................................


Patch Set 3:

Giving yourself a +1. Mhm. Interesting.
Corey was about creating a separate commit, so he is able to see it via the headline already. 

Anyway, complete different approach: What about keeping the sRTP part and remove sRTP in each package list? Rationale: All supported platforms come with an sRTP library. However, none of the platforms compiled it with OpenSSL enabled. Therefore AES-GCM is not possible – supported in Asterisk 15. And more interesting for Asterisk as a VoIP server: AES-IN are not used. Finally, a security library should come/use the latest security patches. Only a few of the supported platforms offer the latest version. Even then, it is not updated when an issue is found.

In other words: sRTP should not rely on the package from the platform but built manually, especially for a server like Asterisk. Therefore: What about keeping the checkout of libSRTP and removing the install-package-requests at the top?


-- 
To view, visit https://gerrit.asterisk.org/7835
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbf4b562f81f7c05bd24a3805bd46c0beb4ebd44
Gerrit-Change-Number: 7835
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 19 Jan 2018 08:08:11 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180119/cdcd42d0/attachment.html>


More information about the asterisk-code-review mailing list